Improve AdaptiveTabBar layout when content does not fit #25146
Conversation
|
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30486 | |
| Version | PR #25146 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 08a5b43 | |
| Installation URL | 01331rqc3331o |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30486 | |
| Version | PR #25146 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 08a5b43 | |
| Installation URL | 4t0i9j8409a0g |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
| width: ceil(size.width) + contentInsets.leading + contentInsets.trailing + 2, | ||
| height: ceil(size.height) + contentInsets.top + contentInsets.bottom | ||
| ) | ||
| } |
There was a problem hiding this comment.
Is it possible to use auto layout instead?
There was a problem hiding this comment.
Is there something specific that's wrong with the current implementation? I was also kind of skeptical – it was generated – by it seems to make complete sense. This part is in intrinsicContentSize and it calculates how much space is needed and always based on the .medium font. I don't see how you could use Auto Layout in it.
There was a problem hiding this comment.
I don't see anything obvious that's wrong. It's just that we don't typically do layout manually, right? It feels like something you'd do 5 years ago?
Fixes CMM-1159: Fix an issue with AdaptiveTabBar .fill distribution.
Changes
Refactors
AdaptiveTabBarto automatically select the optimal layout based on available width.Additionally:
TabButtoncontrol replacesUIButtonto prevent layout jumping when selection changes font weightScreenshots
Before / After
Stats:
Interactions:
Screen.Recording.2026-01-19.at.5.23.58.PM.mov