Add WordAdsMetric and related APIs #25152
Open
+843
−209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30590 | |
| Version | PR #25152 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 223d195 | |
| Installation URL | 69scb91t3pho8 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30590 | |
| Version | PR #25152 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 223d195 | |
| Installation URL | 5s8s7quugbnn0 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
kean
force-pushed
the
task/add-chart-view
branch
2 times, most recently
from
95beb65 to
246d20b
Compare
kean
force-pushed
the
task/add-chart-view
branch
from
246d20b to
223d195
Compare
|
kean
commented
Jan 23, 2026
|
|
||
| /// A legacy variant of `WordPressKit.StatsTimeIntervalData` API that supports | ||
| /// only support setting the target date and the quantity of periods to return. | ||
| func getData<TimeStatsType: WordPressKit.StatsTimeIntervalData>( |
Contributor
Author
There was a problem hiding this comment.
Most of this code was simply moved from the bottom of StatsService.swift. The only addition is the method:
/// A legacy variant of `WordPressKit.StatsTimeIntervalData` API that supports
/// only support setting the target date and the quantity of periods to return.
func getData<TimeStatsType: WordPressKit.StatsTimeIntervalData>(
date: Date,
unit: WordPressKit.StatsPeriodUnit,
quantity: Int
) async throws -> TimeStatsType where TimeStatsType: Sendable {
kean
commented
Jan 23, 2026
|
|
||
| func getWordAdsStats(date: Date, granularity: DateRangeGranularity) async throws -> WordAdsMetricsResponse { | ||
| // Check cache first | ||
| let cacheKey = WordAdsStatsCacheKey(date: date, granularity: granularity) |
Contributor
Author
There was a problem hiding this comment.
There is a little bit of duplication, but it's still easy to read and understand, and I wanted to limit the impact on the existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of CMM-1132: Add WordAds revenue stats to Jetpack app.
Changes
/wordads/statsendpoint and the related types to parse it (WordPressKit) and to map for the Stats screen (WordAdsMetric)MetricTypeprotocol to generalize that code that previous supported onlyStatsMetric(views, visitors, etc)Testing Instructions
n/a (the relevant parts are covered by unit tests)