Fix regression in displaying previous comparison periods #25212
Merged
Conversation
kean
changed the title
kean
force-pushed
the
fix/granularity-issues
branch
from
2d601bc to
d4e7ae9
Compare
kean
force-pushed
the
fix/granularity-issues
branch
from
d4e7ae9 to
10df03d
Compare
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
crazytonyli
approved these changes
Feb 4, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zip, so the chart would no longer display all the previous points for the incomplete periods such as "This Week"extendedDomainintroduced in Stats: Charts improvements and fixes #25185 to only be applied when it's needed: data points not visible on the chart. I also simplified it a bit. I kind of looks bad, but I just wanted to make sure it doesn't affect non-weird scenarios. We can get back to it later.Screenshot
Before / After
Before / After
The weird "year" granularity for short period like "7 days" screnario
