Skip to content

adding three new conection types to node SDK connection type enums #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rarevalo13 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adding three new conection types to node SDK connection type enums #1389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sso/interfaces/connection-type.enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ export enum ConnectionType {
Auth0SAML = 'Auth0SAML',
AzureSAML = 'AzureSAML',
CasSAML = 'CasSAML',
CleverOIDC = 'CleverOIDC',
Copy link
Contributor

@greptile-apps greptile-apps bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Inconsistent casing: this uses OIDC (all caps) while existing AdpOidc and LoginGovOidc use Oidc (camelCase). GenericOIDC uses caps, so there's already inconsistency in the codebase.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/sso/interfaces/connection-type.enum.ts
Line: 8:8

Comment:
**style:** Inconsistent casing: this uses `OIDC` (all caps) while existing `AdpOidc` and `LoginGovOidc` use `Oidc` (camelCase). `GenericOIDC` uses caps, so there's already inconsistency in the codebase.

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Contributor

@gcarvelli gcarvelli Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These casings match the API. Looks good

ClassLinkSAML = 'ClassLinkSAML',
CloudflareSAML = 'CloudflareSAML',
CyberArkSAML = 'CyberArkSAML',
DuoSAML = 'DuoSAML',
EntraIdOIDC = 'EntraIdOIDC',
GenericOIDC = 'GenericOIDC',
GenericSAML = 'GenericSAML',
GitHubOAuth = 'GitHubOAuth',
Expand All @@ -22,6 +24,7 @@ export enum ConnectionType {
MicrosoftOAuth = 'MicrosoftOAuth',
MiniOrangeSAML = 'MiniOrangeSAML',
NetIqSAML = 'NetIqSAML',
OktaOIDC = 'OktaOIDC',
OktaSAML = 'OktaSAML',
OneLoginSAML = 'OneLoginSAML',
OracleSAML = 'OracleSAML',
Expand Down