Skip to content

Conversation

@gjtorikian
Copy link
Contributor

Description

Got the wrong var names here.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

@gjtorikian gjtorikian requested a review from a team as a code owner January 22, 2026 20:00
@gjtorikian gjtorikian requested a review from nicknisi January 22, 2026 20:00
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 22, 2026

Greptile Summary

This PR corrects the GitHub Actions workflow variable names used for GitHub App token generation across the release and version-bump workflows. The variable references were updated from WORKOS_BOT_APP_ID and WORKOS_BOT_PRIVATE_KEY to SDK_BOT_APP_ID and SDK_BOT_PRIVATE_KEY respectively, aligning with the actual configured secret and variable names. These changes ensure the workflows can properly authenticate with the correct bot credentials.

  • Both .github/workflows/release.yml and .github/workflows/version-bump.yml have been corrected
  • The changes are minimal, focused, and address the stated issue
  • No functional impact beyond ensuring proper variable resolution

Confidence Score: 5/5

  • This PR is safe to merge with no concerns
  • This is a straightforward variable name correction in GitHub Actions workflows. The changes are minimal (4 lines across 2 files), focused, and directly address the issue stated in the PR description. Both files only change the variable names from WORKOS_BOT to SDK_BOT, with no logic changes or potential for introducing bugs. The changes simply ensure proper variable resolution in the workflows.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/release.yml Fixed variable names in GitHub App token generation. Changed vars.WORKOS_BOT_APP_ID to vars.SDK_BOT_APP_ID and secrets.WORKOS_BOT_PRIVATE_KEY to secrets.SDK_BOT_PRIVATE_KEY. This is a straightforward correction with no issues.
.github/workflows/version-bump.yml Fixed variable names in GitHub App token generation. Changed vars.WORKOS_BOT_APP_ID to vars.SDK_BOT_APP_ID and secrets.WORKOS_BOT_PRIVATE_KEY to secrets.SDK_BOT_PRIVATE_KEY. This is a straightforward correction with no issues.

Sequence Diagram

sequenceDiagram
    participant GitHub as GitHub Actions
    participant Secrets as GitHub Secrets/Variables
    participant App as GitHub App Token
    participant Workflow as Release/Version-Bump Workflow

    GitHub->>Secrets: Request SDK_BOT_APP_ID var
    Secrets-->>GitHub: Return correct app ID
    GitHub->>Secrets: Request SDK_BOT_PRIVATE_KEY secret
    Secrets-->>GitHub: Return correct private key
    GitHub->>App: Generate token with correct credentials
    App-->>GitHub: Return authentication token
    GitHub->>Workflow: Execute workflow with valid token
    Workflow-->>GitHub: Workflow completes successfully
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gjtorikian
Copy link
Contributor Author

damn, nice, thanks @gcarvelli

@gjtorikian gjtorikian merged commit 40d8fea into main Jan 22, 2026
11 checks passed
@gjtorikian gjtorikian deleted the use-correct-names branch January 22, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants