Safeguard remove cap from collisions with roles#530
Merged
schlessera merged 6 commits intowp-cli:mainfrom May 6, 2025
Merged
Conversation
…y same as role
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Member
|
Thanks for starting this! The example you mentioned would make for a good Behat test :-) Would you be up for adding one? |
Contributor
Author
|
Sure @swissspidy I'll add the Behat test. Thank you. |
Contributor
Author
|
@swissspidy added behat test. Let me know if this works. |
Member
|
The original suggestion in #98 (comment) was to add a |
Contributor
Author
|
@swissspidy I've added |
47 tasks
2f02b38 to
19aa208
Compare
schlessera
approved these changes
May 6, 2025
remove cap from collisions with roles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
Let's start with this:
ExMemberand capabilityexmemberwp user remove-cap 1 exmemberwp user remove-roleinstead.