Display extension names during bulk updates #492
+77
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wp plugin update --allandwp theme update --allprovide no indication of which extension is currently being updated, making it difficult to track progress or identify problematic updates.Changes
Added
ExtensionUpgraderSkin- Extends baseUpgraderSkinwithbefore()method that outputs "Updating {name}..." before each update operation$this->plugin_info['Name']array$this->theme_info->get('Name')WP_Theme objectModified
CommandWithUpgrade::get_upgrader()- Instantiates upgraders withExtensionUpgraderSkininstead of defaultUpgraderSkinUtils\get_upgrader()as skin must be passed to constructorAdded test coverage - Behat scenarios verify correct name display for both plugin and theme bulk updates
Example Output
Before:
After:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.wordpress.org/usr/bin/curl curl -s REDACTED(dns block)downloads.wordpress.org/usr/bin/curl curl -sSfL REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>wp plugin update all doesnt display info which plugin is being updated</issue_title>
<issue_description>The output for all plugins updated is always this:
Would be much more helpful if it at least said once which plugin it is updating in a separate line first.</issue_description>
Comments on the Issue (you are @copilot in this section)
@danielbachhuber > Would be much more helpful if it at least said once which plugin it is updating in a separate line first.I agree!</comment_new>
<comment_new>@danielbachhuber
I think it would still be nice to indicate the plugin in the log output, e.g.: