Fix docstring indent issue in feature files#85
Merged
swissspidy merged 1 commit intomainfrom Apr 10, 2025
Merged
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
swissspidy
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
In our feature tests, we generally use indented docstring block. Majority of tests use this convention but there are some files which does not abide this.
Since there is no rules for this in
gherkin-lint, I have developed custom rule forgherkin-lint. https://github.com/ernilambar/gherkin-lint-rules/blob/main/custom-rules/docstring-indent.jsCurrently I am running this locally to detect issue and working on preparing PR for WPCLI repos. We can also integrate this rule in the central repo if deemed feasible.