Skip to content

Tell wordpress we support url rewriting#92

Open
ssnepenthe wants to merge 1 commit intowp-cli:mainfrom
ssnepenthe:permalinks-wo-index
Open

Tell wordpress we support url rewriting#92
ssnepenthe wants to merge 1 commit intowp-cli:mainfrom
ssnepenthe:permalinks-wo-index

Conversation

@ssnepenthe
Copy link

See #91

@ssnepenthe ssnepenthe requested a review from a team as a code owner February 4, 2026 21:25
@gemini-code-assist
Copy link

Summary of Changes

Hello @ssnepenthe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial change to the development router configuration, enabling WordPress's native URL rewriting capabilities. By explicitly declaring support for URL rewriting, the change ensures that permalinks and other URL-dependent features within WordPress will function as expected in the development environment.

Highlights

  • WordPress URL Rewriting Support: Added add_filter( 'got_url_rewrite', '__return_true' ); to router.php to explicitly inform WordPress that URL rewriting is available, ensuring permalinks function correctly.
Changelog
  • router.php
    • Added add_filter( 'got_url_rewrite', '__return_true' ); to signal WordPress that URL rewriting is supported, which is essential for proper permalink functionality.
Activity
  • No human activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly enables URL rewriting support for the built-in PHP server used by wp server. This is achieved by adding a got_url_rewrite filter, which will allow WordPress to use pretty permalinks. The change is straightforward and effective. I have one suggestion to improve code clarity by adding a comment.

20
);

add_filter( 'got_url_rewrite', '__return_true' );

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other filters in this file (like the one for option_home) and for better readability, it would be helpful to add a comment explaining the purpose of this filter. This will make it clearer to future maintainers why this line is necessary.

// Tell WordPress we support URL rewriting, so that pretty permalinks work.
add_filter( 'got_url_rewrite', '__return_true' );

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant