Skip to content

Coverage: fix Selector usage #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 2 commits into from
May 7, 2025
Merged

Coverage: fix Selector usage #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6ff933
Coverage: fix Selector usage
swissspidy May 7, 2025
9aed84f
Update `merge_coverage_reports` too
swissspidy May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Context/FeatureContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
use Behat\Behat\Hook\Scope\BeforeStepScope;
use SebastianBergmann\CodeCoverage\Report\Clover;
use SebastianBergmann\CodeCoverage\Driver\Selector;
use SebastianBergmann\CodeCoverage\Driver\Xdebug;
use SebastianBergmann\CodeCoverage\Filter;
use SebastianBergmann\CodeCoverage\CodeCoverage;
use SebastianBergmann\Environment\Runtime;
Expand Down Expand Up @@ -198,7 +199,8 @@

$filter = new Filter();
$coverage = new CodeCoverage(
( new Selector() )->forLineCoverage( $filter ),
// Selector class was only added in v9.1 of the php-code-coverage library.
class_exists( Selector::class ) ? ( new Selector() )->forLineCoverage( $filter ) : ( new Xdebug() ),

Check warning on line 203 in src/Context/FeatureContext.php

View check run for this annotation

Codecov / codecov/patch

src/Context/FeatureContext.php#L203 

Added line #L203 was not covered by tests
$filter
);

Expand Down
4 changes: 3 additions & 1 deletion utils/generate-coverage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

use SebastianBergmann\CodeCoverage\CodeCoverage;
use SebastianBergmann\CodeCoverage\Driver\Selector;
use SebastianBergmann\CodeCoverage\Driver\Xdebug;
use SebastianBergmann\CodeCoverage\Filter;
use SebastianBergmann\CodeCoverage\Report\PHP as PHPReport;

Expand Down Expand Up @@ -81,7 +82,8 @@ function ( $file ) {
}

$coverage = new CodeCoverage(
( new Selector() )->forLineCoverage( $filter ),
// Selector class was only added in v9.1 of the php-code-coverage library.
class_exists( Selector::class ) ? ( new Selector() )->forLineCoverage( $filter ) : ( new Xdebug() ),
$filter
);

Expand Down