fix: Fixed post type initialisation before ACF hooks#370
Merged
colinmurphy merged 4 commits intomainfrom Aug 13, 2025
Merged
Conversation
…e is setting values in the constructor means ACF hooks have not fired.
🦋 Changeset detectedLatest commit: fc66722 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
ℹ️ Download the latest hwp-previews plugin zip from this PR |
…gine/hwptoolkit into bug-fix-acf-post-types-for-previews
ahuseyn
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e is setting values in the constructor means ACF hooks have not fired.
Description
Issue is that ACF post types are not being picked up HWP Previews for the settings page (or any other related post type functionality).
After some investigating it was the Post Preview Service is being called before ACF hook initialisation to register those custom post types.
Fix: A small refactor that the post preview service would not set post_type, post_status on initialisation but rather when a getter method is called, to check if the property is not empty and then set the data.
Related Issue
Fixes #368
Dependant PRs
Type of Change
How Has This Been Tested?
Screenshots
Checklist