Add writeas config command#25
Open
a-mt wants to merge 1 commit intowriteas:developfrom
a-mt:writeas-config
Open
Add writeas config command#25a-mt wants to merge 1 commit intowriteas:developfrom a-mt:writeas-config
a-mt wants to merge 1 commit intowriteas:developfrom
a-mt:writeas-config
Conversation
|
Hi @a-mt, this is actually something that is being discussed over on our phabricator https://phabricator.write.as/T596 The errors were a bit all over, there have been a lot of changes since you opened this - sorry about that. There will likely be more changes needed to clean things up further as well. If you are still interested in working on this let us know, and maybe come by our phabricator to discuss details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the command "config", to be able to easily edit the user configurations.
I know you didn't ask for it, feel free to reject it.
If you don't, here's some reservations that I have:
I don't understand how the errors are handled
commands.go:
fonts.go:
options.go:
posts.go:
Basically, I don't understand in which cases errors should be returned rather than printed, and with which method :/
When the user doesn't give the right options / arguments:
Shouldn't we print the command usage and its options, using
cli.ShowSubcommandHelp(c)(the same output aswriteas COMMAND --help) and putting the usage in the fieldUsageText(cli.go), rather than callingcli.NewExitError("usage: writeas ...", 1)?Looking forward to your feedback!