fix(onFulfill): make sure to fire once per code fulfill#110
Open
tastydev wants to merge 1 commit intoxamous:masterfrom
Open
fix(onFulfill): make sure to fire once per code fulfill#110tastydev wants to merge 1 commit intoxamous:masterfrom
tastydev wants to merge 1 commit intoxamous:masterfrom
Conversation
onFulfill always fired twice before which caused bugs if implementations rely on code fulfill event detection i.e to post requests automatically. Ths fix will make sure to only fire 1 event per code completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onFulfill always fired twice before which caused bugs if implementations rely on code fulfill event detection i.e to post requests automatically. Ths fix will make sure to only fire 1 event per code completion