Skip to content

Fix regrid.stats for unsorted input coords #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BSchilperoort merged 4 commits into from
Apr 8, 2025
Merged

Fix regrid.stats for unsorted input coords #58

BSchilperoort merged 4 commits into from
Apr 8, 2025

Conversation

@BSchilperoort
Copy link
Contributor

@BSchilperoort BSchilperoort commented Apr 8, 2025

Fixes #55

@BSchilperoort
Copy link
Contributor Author

BSchilperoort commented Apr 8, 2025

Hi @slevang, I found some time to fix a bug that has been present in the stats methods. Would you be able to look at this PR? I basically copied what you did in a5788bf

I also bumped the version so we can release the bug fixes.

slevang
slevang approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@slevang slevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BSchilperoort
Copy link
Contributor Author

BSchilperoort commented Apr 8, 2025

👍

Thanks! 😄

@BSchilperoort BSchilperoort merged commit 8411437 into main Apr 8, 2025
11 checks passed
@BSchilperoort BSchilperoort deleted the unordered-stats branch April 8, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slevang slevang slevang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

regrid.stat methods can break when coords are not sorted in ascending order

3 participants

@BSchilperoort @slevang