Skip to content

Conversation

@BSchilperoort
Copy link
Contributor

Closes #24

@BSchilperoort BSchilperoort requested a review from slevang April 9, 2025 06:50
Copy link
Collaborator

@slevang slevang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. The mypy failure seems to be real, although unrelated to this PR. I reran the docs build which went through.

@BSchilperoort
Copy link
Contributor Author

Great. The mypy failure seems to be real, although unrelated to this PR. I reran the docs build which went through.

Something must have changed in a dependency. If I create a new environment from scratch, I can reproduce the error.

For some reason mypy things dy on this line is of type str | Unknown, because of the .item() call.

dy = obj.coords[lat_coord].diff(lat_coord).max().values.item()

Changing this to;

    dy: Any = obj.coords[lat_coord].diff(lat_coord).max().values.item() 

makes mypy happy again :/

@BSchilperoort BSchilperoort mentioned this pull request Apr 11, 2025
@BSchilperoort BSchilperoort requested a review from slevang April 11, 2025 08:10
@BSchilperoort BSchilperoort linked an issue Apr 11, 2025 that may be closed by this pull request
@BSchilperoort BSchilperoort merged commit eef312a into main Apr 11, 2025
11 checks passed
@BSchilperoort BSchilperoort deleted the add-conda-badge branch April 11, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix mypy issue Add to conda-forge

3 participants