CP-310799 Enhance ACK Test Case Selection Functionality #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Catherine Liu <catherine.liu@cloud.com>
Signed-off-by: Catherine Liu <catherine.liu@cloud.com>
| def normalize_test_class_name(n): | ||
| while n.startswith("autocertkit."): | ||
| n = n[11:] | ||
| return n |
Collaborator
There was a problem hiding this comment.
I don't see why we need this function.
| However, if there is a failure such that the ack-submission package is not created, then we would ask that you submit the following: | ||
|
|
||
| - Server Status Report - this can be obtained either by either running the ‘xen-bugtool –y’ command on the coordinator host, or by using XenCenter (Tools - Get Server Status Report). | ||
| - Server Status Report - this can be obtained either by either running the ‘xen-bugtool -y’ command on the coordinator host, or by using XenCenter (Tools - Get Server Status Report). |
Collaborator
There was a problem hiding this comment.
It's not introduced in this PR, but there're two either: obtained either by either
| if "run_classes" not in config: | ||
| return | ||
|
|
||
| from test_generators import enumerate_all_test_classes |
Collaborator
There was a problem hiding this comment.
I don't think it's necessary to import here, as test_generators is already imported at top of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the ACK test case selection functionality with the following improvements:
In addition to these functional changes, this PR also updates the publication date to align with the latest release plan.
Regression test (232076) has passed
Following test case also passed with manual test:
"run_classes=network_tests.MulticastTestClass
network_tests.IntraHostSRIOVTestClass2
operations_tests.CrashDumpTestClass"