Add JDK 25 to CI test matrix #703
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CI to test on JDK 25 (LTS) and remove JDK 24 (non-LTS). Changes: - Replace JDK 24 with JDK 25 in test matrix - Add --enable-native-access=ALL-UNNAMED flag for JDK 24+ tests - This ensures native library loading works correctly per JEP 472 The CI now tests on: JDK 8, 11, 17, 21, 25 (all LTS versions plus latest) Related to #689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
This PR updates the CI workflow to test on JDK 25 and properly handle the native access requirements introduced in JEP 472.
Changes
--enable-native-access=ALL-UNNAMEDWhy JDK 25 instead of JDK 24?
JDK 25 is an LTS release, while JDK 24 is not. Testing on LTS versions ensures better long-term compatibility.
Why the
_JAVA_OPTIONSflag?As documented in #702, snappy-java uses JNI to load native libraries. JDK 24+ requires the
--enable-native-access=ALL-UNNAMEDflag per JEP 472. Setting this in CI ensures our tests run cleanly on newer JDKs.Test plan
Related to #689
🤖 Generated with Claude Code