Draft
Conversation
Author
|
May be of use for #36 |
Owner
|
Sorry to come back only now. Is there a way to have a simple test added for this? (We do have some binary files in https://github.com/xoofx/LibObjectFile/tree/master/src/LibObjectFile.Tests/Elf for instance) |
Author
|
Yep, I can get some added in the upcoming weeks |
xoofx
reviewed
Jan 26, 2026
| } | ||
|
|
||
| internal bool TryGetString(uint index, out string text) | ||
| public bool TryGetString(uint index, out string text) |
Author
There was a problem hiding this comment.
I needed that for a different project because there was no way to get a string via index otherwise (or at least I didn't see it) I can revert it when I submit the tests and other fixes I've found along the way =]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work, I really need this support for a different project. So I got it working for my needs.
Let me know if there's anything in particular that doesn't look right, I was kinda going off of guessing/referencing other classes.