Add option to specify camera axis direction#3
Open
Conversation
Author
|
Resolves #4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I have added a feature that allows the user to specify the direction that the camera (boresight) axis is pointing to, either in the positive or negative z directions.
The original code had -z by default which I found surprising because in my line of work, +z is the norm. So I'm adding this for other people who might have the same experience.
I am open for suggestions and if you agree @xt4d I will add some docstrings to the methods to explain the new option along with the other, pre-existing arguments. I would also like to add being able to specify -/+ x/y axes for the camera axis in the future.
Note: One has to be careful when specifying -z as an option on the command line, the string needs to be properly escaped and passed to the option like this:
--camera_axis="-z"Thanks!
PS: Here an illustration that shows the new feature:
