MSVC/AVX512F: Fix batch_const with 16b and 8b integers. #1150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no _setr_ intrinsic for 16b and 8b types, so we have to flip the order ourself. Honestly, why is there no CI for catching this bug? Can we have an MSVC+AVX512 CI runner please?
Contributor
Author
|
Oh dear: https://github.com/xtensor-stack/xsimd/blob/master/.github/workflows/windows.yml#L53 ... FYI: With this patch, |
degasus
changed the title
Contributor
|
Thanks! I'll have a look on this CI thing, it's frightening. |
Contributor
|
ok, we do test avx512 on Linux, (through emulation) and not on windows (see actions/runner#1069) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no
_setr_intrinsic for 16b and 8b types, so we have to flip the order ourself.Honestly, there is a CI for catching such bugs. How can we missed to test this case?