-
-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate from webextension-toolbox to WXT #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d44588
feat: migrate from webextension-toolbox to wxt
yamadashy 4c17950
fix: add tabs permission for background script injection
yamadashy 2f6661e
fix: filter GitHub tabs in background script injection
yamadashy 834ad51
fix: handle document.head availability in CSS injection
yamadashy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| export default defineBackground(() => { | ||
| const injectContentToTab = async (tab: chrome.tabs.Tab): Promise<void> => { | ||
| // Skip if URL is undefined | ||
| if (!tab.url) { | ||
| return; | ||
| } | ||
|
|
||
| // Skip if tab is discarded | ||
| if (tab.discarded) { | ||
| return; | ||
| } | ||
|
|
||
| // Skip if tab ID is undefined | ||
| if (tab.id === undefined) { | ||
| return; | ||
| } | ||
|
|
||
| // Skip if not a GitHub URL | ||
| if (!tab.url.startsWith('https://github.com/')) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| const manifest = chrome.runtime.getManifest(); | ||
|
|
||
| // Inject CSS | ||
| if (manifest.content_scripts?.[0]?.css) { | ||
| await chrome.scripting.insertCSS({ | ||
| target: { tabId: tab.id }, | ||
| files: manifest.content_scripts[0].css, | ||
| }); | ||
| } | ||
|
|
||
| // Inject JavaScript | ||
| if (manifest.content_scripts?.[0]?.js) { | ||
| await chrome.scripting.executeScript({ | ||
| target: { tabId: tab.id }, | ||
| files: manifest.content_scripts[0].js, | ||
| }); | ||
| } | ||
| } catch (error) { | ||
| console.error('Error injecting content script:', error); | ||
| } | ||
| }; | ||
|
|
||
| // Inject content scripts to existing GitHub tabs when extension is installed/updated | ||
| chrome.tabs.query({ url: 'https://github.com/*' }, async (tabs: chrome.tabs.Tab[]) => { | ||
| for (const tab of tabs) { | ||
| try { | ||
| await injectContentToTab(tab); | ||
| } catch (e) { | ||
| console.error(e); | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script for programmatically injecting the content script appears to be a holdover from the previous build system and is likely redundant. Modern browsers automatically inject manifest-defined content scripts into existing, matching tabs upon extension installation or update.
Furthermore, the current implementation is brittle as it relies on the specific structure of the auto-generated manifest (
manifest.content_scripts[0]).Recommendation:
defineBackground."scripting"permission fromwxt.config.tsas it will no longer be needed. This reduces the extension's permission footprint, which is a security best practice.