-
-
Notifications
You must be signed in to change notification settings - Fork 41
Us counties 2020 list #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wrote a test here to capture the difference between the old and new outputs. As you can see, most are due to special characters (in PR county names) and a few census name changes that happened between 2010 and 2020 Output below (and reasons for changes manually added by me) |
Owner
|
Thanks for the PR Connor! I merged your code from the command line. Before I create a new release, I need a solution for #43 though. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
For us_counties, change the counties URL to use the published 2020 version. This version contains a few changes described here
Fixes #44
Changelog
Testing
After running
make dl && make json, the new us_counties.json contains entries for each of the counties mentioned in #44Taken by manually scanning us_counties.json