Skip to content

Comments

Improve prod-deploy error handling#421

Merged
samdark merged 6 commits intomasterfrom
better-deploy
Feb 20, 2026
Merged

Improve prod-deploy error handling#421
samdark merged 6 commits intomasterfrom
better-deploy

Conversation

@samdark
Copy link
Member

@samdark samdark commented Dec 25, 2025

This change improves deploy error handling so in case of rollback, it will print out the exact reason why it happened.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copilot AI review requested due to automatic review settings December 25, 2025 09:16
@samdark samdark added the type:enhancement Enhancement label Dec 25, 2025
@samdark samdark requested a review from a team December 25, 2025 09:16
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (46666f1) to head (255b31f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #421   +/-   ##
=========================================
  Coverage     76.96%   76.96%           
  Complexity       29       29           
=========================================
  Files            11       11           
  Lines           178      178           
=========================================
  Hits            137      137           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the prod-deploy Makefile target to better handle deployment failures by detecting Docker Swarm rollbacks and providing diagnostic information about the failed deployment.

Key Changes

  • Captures deployment output to a log file for analysis
  • Detects rollback events through pattern matching
  • Attempts to extract and display logs from failed tasks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line to changelog

samdark and others added 4 commits December 26, 2025 20:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@samdark
Copy link
Member Author

samdark commented Dec 26, 2025

Needs to be tested well before merge.

@samdark samdark merged commit faf21f4 into master Feb 20, 2026
16 checks passed
@samdark samdark deleted the better-deploy branch February 20, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants