-
Notifications
You must be signed in to change notification settings - Fork 317
Removing deprecated Docker Version String from compose file #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks wasn't checking the history. I would add a comment to the file, so it's clear WHY there is still a version tag? If thats good for you I will submit another commit within this PR? |
|
Maybe a simple comment above 'version x' that points to PR#416 might be a good idea to reduce the constant confusion from others. |
|
We should check this again. Maybe we can drop the version now when we do the change for Zammad 7.0. |
|
I think we can do this for Zammad 7.0. There are more docker compose files in the |
|
Sure! Leave it wit me. Happy to update the other ones. |
|
Hi - Sorry was busy with other task. Will provide an update this week! SORRY For the delay! |
|
This PR has been automatically marked as stale because it has not had recent activity. |
PR Description
This PR removes the explicit version string (
version: "3") from thedocker-compose.yml.Rationale
Deprecated in Compose Specification
The Docker Compose specification no longer requires or recommends using the
versionfield. Starting with Compose v1.27.0 and the introduction of the Compose Specification, theversionkey has been deprecated.Improved Forward Compatibility
By removing the version declaration, the file is parsed against the latest Compose specification by default. This ensures that new features and improvements introduced in Compose will be available without needing to bump the version manually.
Reduces Maintenance Overhead
Explicit version numbers can cause unnecessary churn and confusion, especially when developers assume they must be updated with new Docker releases. Omitting the field simplifies the file and avoids misleading future contributors.
Broad Compatibility
Modern Docker and Docker Compose versions handle files without
version:seamlessly. Keeping it in place only creates the impression that specific constraints exist, which is no longer the case.References
Summary
This change aligns the Zammad
docker-compose.ymlwith current Docker best practices, reduces confusion, and improves maintainability going forward.