-
-
Notifications
You must be signed in to change notification settings - Fork 374
Fix deprecation of setting shape on a numpy array in 2.5+ #3648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation of setting shape on a numpy array in 2.5+ #3648
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
=======================================
Coverage 60.90% 60.90%
=======================================
Files 86 86
Lines 10174 10174
=======================================
Hits 6196 6196
Misses 3978 3978
🚀 New features to boost your workflow:
|
d-v-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
|
@d-v-b Note that this change is not fully backward compatible, if we want it backward compatible we would set
If we set |
|
As |
|
Well it should- and personally I don't see the harm in adding this fallback- but if you prefer to have an explicit raise instead to catch eventual future changes that would somehow yield a non contiguous array of objects, then setting |
|
in that case the |
Fixes deprecation observed in
numpy2.5+ (pre-release):