-
-
Notifications
You must be signed in to change notification settings - Fork 37
doc: v3 beta.27 release #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughDocumentation updates across three files expand multi-runtime support guidance. FAQ now explicitly enumerates runtime statuses (Node.js systematically tested; Bun and Vercel Edge basic tests; Deno untested). SQLite recipe adds Bun-specific setup and code examples. Sample projects section introduces a Rallly fork reference. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
versioned_docs/version-3.x/recipe/databases/sqlite.md (1)
28-47: Bun section well-structured; minor wording improvements recommended.The new Bun section provides clear setup guidance, proper package dependency, and a working code example. However, two minor improvements are suggested:
- Line 32: Change "builtin" to "built-in" (hyphenated for proper English)
- Line 32: Optionally change "not compatible" to "incompatible" for conciseness
Apply this diff for the wording improvements:
-Bun is not compatible with `better-sqlite3`. You can use its builtin `bun:sqlite` module with the `kysely-bun-sqlite` Kysely community dialect. +Bun is incompatible with `better-sqlite3`. You can use its built-in `bun:sqlite` module with the `kysely-bun-sqlite` Kysely community dialect.Please verify that the package references (
kysely-bun-sqlite) and import paths (bun:sqlite,BunSqliteDialect) are current and match the latest library documentation, as Bun's ecosystem is rapidly evolving.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
versioned_docs/version-3.x/faq.md(1 hunks)versioned_docs/version-3.x/recipe/databases/sqlite.md(2 hunks)versioned_docs/version-3.x/samples.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
versioned_docs/version-3.x/samples.md
[grammar] ~22-~22: Ensure spelling is correct
Context: ...s, TanStack Query, and ZenStack v3. ## Rallly https://github.com/zenstackhq/rallly [R...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
versioned_docs/version-3.x/recipe/databases/sqlite.md
[style] ~32-~32: Consider using “incompatible” to avoid wordiness.
Context: ... ## Bun ### Installing driver Bun is not compatible with better-sqlite3. You can use its ...
(NOT_ABLE_PREMIUM)
[grammar] ~32-~32: Ensure spelling is correct
Context: ... with better-sqlite3. You can use its builtin bun:sqlite module with the `kysely-bu...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
versioned_docs/version-3.x/samples.md
24-24: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (3)
versioned_docs/version-3.x/samples.md (1)
22-26: Sample project entry is well-structured and adds valuable reference.The Rallly fork description clearly communicates the value (replaces Prisma with ZenStack v3) and fits naturally with existing samples.
versioned_docs/version-3.x/recipe/databases/sqlite.md (1)
9-26: Node.js section restructuring improves clarity.Nesting "Installing driver" under a "Node.js" heading clearly distinguishes this from other runtime options and improves documentation navigation.
versioned_docs/version-3.x/faq.md (1)
17-20: Clear and informative runtime support statement.The explicit enumeration of runtime testing statuses (Node.js systematically tested; Bun and Vercel Edge basic tests; Deno untested) provides actionable clarity for users evaluating ZenStack v3 compatibility. This aligns well with the Bun-specific guidance added in the SQLite recipe and reflects the broader multi-runtime support improvements in this release.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.