Skip to content

Commit f2cf818

Browse files
dcpleungcfriedt
authored andcommitted
xtensa: fatal: use named macros for PS register bits...
...instead of magic numbers when printing exception information. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
1 parent 0f8f14e commit f2cf818

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

arch/xtensa/core/vector_handlers.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,13 @@ static void print_fatal_exception(void *print_stack, int cause,
259259

260260
EXCEPTION_DUMP(" ** PS %p", (void *)bsa->ps);
261261
EXCEPTION_DUMP(" ** (INTLEVEL:%d EXCM: %d UM:%d RING:%d WOE:%d OWB:%d CALLINC:%d)",
262-
get_bits(0, 4, ps), get_bits(4, 1, ps),
263-
get_bits(5, 1, ps), get_bits(6, 2, ps),
264-
get_bits(18, 1, ps),
265-
get_bits(8, 4, ps), get_bits(16, 2, ps));
262+
get_bits(XCHAL_PS_INTLEVEL_SHIFT, XCHAL_PS_INTLEVEL_BITS, ps),
263+
get_bits(XCHAL_PS_EXCM_SHIFT, XCHAL_PS_EXCM_BITS, ps),
264+
get_bits(XCHAL_PS_UM_SHIFT, XCHAL_PS_UM_BITS, ps),
265+
get_bits(XCHAL_PS_RING_SHIFT, XCHAL_PS_RING_BITS, ps),
266+
get_bits(XCHAL_PS_WOE_SHIFT, XCHAL_PS_WOE_BITS, ps),
267+
get_bits(XCHAL_PS_OWB_SHIFT, XCHAL_PS_OWB_BITS, ps),
268+
get_bits(XCHAL_PS_CALLINC_SHIFT, XCHAL_PS_CALLINC_BITS, ps));
266269
}
267270

268271
static ALWAYS_INLINE void usage_stop(void)

0 commit comments

Comments
 (0)