Skip to content

Conversation

@JoeJRW
Copy link
Contributor

@JoeJRW JoeJRW commented Nov 10, 2025

Alibaba Cloud RDS MySQL introduced vector support in version 20251031.

We sincerely appreciate all the work on vectordbbench. Supporting AliSQL would enable us to include vectordbbench in our official documentation, and allow our customers to better evaluate AliSQL's vector capabilities. We hope this contribution will be helpful to both projects and their users.

@JoeJRW
Copy link
Contributor Author

JoeJRW commented Nov 10, 2025

/assign @XuanYang-cn

@alwayslove2013
Copy link
Contributor

@JoeJRW Thank you so much for your contribution!
We noticed there are some conflicts in this pull request. Could you please resolve them? After that, we'll be happy to merge it.

@JoeJRW JoeJRW force-pushed the feat_cli_alibaba_cloud_rds_mysql branch 2 times, most recently from 5884326 to 5c7fc13 Compare November 25, 2025 09:36
@JoeJRW
Copy link
Contributor Author

JoeJRW commented Nov 25, 2025

@alwayslove2013 Thank you for your review.

I have resolved the conflict. Please check again.

@alwayslove2013
Copy link
Contributor

@JoeJRW, there are some lint issues.

pip install black ruff --upgrade
make format
make lint

* Alibaba Cloud RDS MySQL introduced vector support in version 20251031
@JoeJRW JoeJRW force-pushed the feat_cli_alibaba_cloud_rds_mysql branch from 5c7fc13 to a9275fc Compare November 25, 2025 10:14
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, JoeJRW
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit f0745b5 into zilliztech:main Nov 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants