fix(cockroachdb): Handle 30s timeout and ensure vector index usage #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viragtripathi
force-pushed
the
fix/cockroachdb-subprocess-timeout
branch
from
df89d8d to
de2f2a3
Compare
Two critical fixes for multi-node CockroachDB clusters: 1. Connection Timeout Handling: On multi-node v25.4 clusters, CREATE VECTOR INDEX from subprocess contexts experiences a 30-second connection timeout. The index creation continues successfully in the background. This fix detects the timeout and polls for completion (up to 5 minutes). 2. Vector Index Usage: Fixed vector_search_beam_size not being set on pooled connections, causing queries to use full table scan instead of the vector index. Now configures every connection from the pool with proper beam size. Testing: - Single-node: Works without timeout (178s index creation) - Multi-node: Successfully handles timeout and completes (131s total) - Vector index: Now properly used for all searches (verified with EXPLAIN) - Both achieve ~83% recall with good QPS Fixes issues where: - Benchmarks would fail despite successful index creation - Searches were slow due to full table scans instead of index usage
viragtripathi
force-pushed
the
fix/cockroachdb-subprocess-timeout
branch
from
e64eaba to
e65f330
Compare
Contributor
Author
|
/assign @XuanYang-cn |
Contributor
Author
|
@alwayslove2013 Please take a look and merge this fix/PR. Thank you! |
alwayslove2013
approved these changes
Nov 27, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alwayslove2013, viragtripathi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two critical fixes for multi-node CockroachDB clusters:
Connection Timeout Handling: On multi-node v25.4 clusters, CREATE VECTOR INDEX from subprocess contexts experiences a 30-second connection timeout. The index creation continues successfully in the background. This fix detects the timeout and polls for completion (up to 5 minutes).
Vector Index Usage: Fixed vector_search_beam_size not being set on pooled connections, causing queries to use full table scan instead of the vector index. Now configures every connection from the pool with proper beam size.
Testing:
Fixes issues where: