Fix dependencies for tutorial#116
Conversation
This fixes the issue of having gcfs installed for the FourCastMini_Demo tutorial.
Pull Request Test Coverage Report for Build 15201583673Details
💛 - Coveralls |
| - pip | ||
| - pip: | ||
| - -e packages/data | ||
| - -e packages/data[download] |
There was a problem hiding this comment.
Remind me the difference between data and data[download]. Should data include the [download] variant options by default?
There was a problem hiding this comment.
What is the purpose of pinning python to 3.11 in this case?
There was a problem hiding this comment.
Remind me the difference between data and data[download]. Should data include the [download] variant options by default?
The [download] suffix will install the following optional dependencies (extract from packages/data/pyproject.toml)
download = [
"cdsapi",
"ecmwf-opendata",
"eccodes",
"gcsfs",
]
I think the intention of the original author of pyearthtools.data was to not force installing the dependencies needed for the download-able data accessors for people not using them. That would be my guess. I don't have a strong opinion about having them included or not in the defaults dependencies of pyearthtools.data.
There was a problem hiding this comment.
What is the purpose of pinning python to 3.11 in this case?
The goal when I made this conda environment file was to make installation more likely to work for a any user, and pinning the version of python as a way to make sure people use a version we were sure was working at the time. Ideally, I wanted to provide a complete environment file with all versions pinned, but it turned out that some dependencies were not working out-of-the-box on Mac (when pinning versions) so I ended up with this version of the environment file.
P.S: This is not part of the PR proposed changes ;-).
|
@tennlee a bit of a digression, but how about we simplify things as follows
So basically anyone installing from a git clone would install everything, like devs. The resulting environment is quite big but... it would just work (tm) :D. I am happy to make the changes (and in the docs), if you want. |
|
I think yes what you propose will simplify what's going on with environments. We can add simplified environments back later if we need to. Please go ahead, and unpin the Python version while at it. I'll merge this PR now. |
Add missing dependencies in the tutorial virtual environment to make FourCastMini demo work.