Skip to content

Fix dependencies for tutorial #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tennlee merged 2 commits into from
May 29, 2025
Merged

Fix dependencies for tutorial #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a54e4c9
add zoo and fourcastnext to the tutorial environment
jennan May 22, 2025
9810a00
ensure downloadable dataset dependencies are installed too
jennan May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tutorials.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ dependencies:
- python=3.11
- pip
- pip:
- -e packages/data
- -e packages/data[download]
Copy link
Collaborator

@tennlee tennlee May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me the difference between data and data[download]. Should data include the [download] variant options by default?

Copy link
Collaborator

@tennlee tennlee May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of pinning python to 3.11 in this case?

Copy link
Collaborator Author

@jennan jennan May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remind me the difference between data and data[download]. Should data include the [download] variant options by default?

The [download] suffix will install the following optional dependencies (extract from packages/data/pyproject.toml)

download = [
  "cdsapi",
  "ecmwf-opendata",
  "eccodes",
  "gcsfs",
]

I think the intention of the original author of pyearthtools.data was to not force installing the dependencies needed for the download-able data accessors for people not using them. That would be my guess. I don't have a strong opinion about having them included or not in the defaults dependencies of pyearthtools.data.

Copy link
Collaborator Author

@jennan jennan May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of pinning python to 3.11 in this case?

The goal when I made this conda environment file was to make installation more likely to work for a any user, and pinning the version of python as a way to make sure people use a version we were sure was working at the time. Ideally, I wanted to provide a complete environment file with all versions pinned, but it turned out that some dependencies were not working out-of-the-box on Mac (when pinning versions) so I ended up with this version of the environment file.

P.S: This is not part of the PR proposed changes ;-).

- -e packages/pipeline
- -e packages/training[lightning]
- -e packages/tutorial
- -e packages/utils
- -e packages/zoo
- -e packages/bundled_models/fourcastnext