fix: handle reorgs in private event store #19327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
commented
Jan 5, 2026
benesjan
commented
Jan 5, 2026
mverzilli
approved these changes
Jan 6, 2026
yarn-project/pxe/src/storage/private_event_store/private_event_store.test.ts
Show resolved
Hide resolved
AztecBot
force-pushed
the
01-05-fix_handle_reorgs_in_private_event_store
branch
from
1720887 to
293608e
Compare
Fixes F-115 We have not yet handled reorgs in `PrivateEventStore`. In this PR I tackle that.
AztecBot
force-pushed
the
01-05-fix_handle_reorgs_in_private_event_store
branch
from
293608e to
0757470
Compare
AztecBot
pushed a commit
that referenced
this pull request
Jan 12, 2026
As Martin mentioned [here](#19327 (comment)) makes sense to have the reorg handling be atomic. In this PR I tackle that. Note that this PR doesn't need to be in stack with #19443 but #19451 depends on both so putting this one into stack was the only way to unblock myself working on #19451.
AztecBot
pushed a commit
that referenced
this pull request
Jan 12, 2026
As Martin mentioned [here](#19327 (comment)) makes sense to have the reorg handling be atomic. In this PR I tackle that. Note that this PR doesn't need to be in stack with #19443 but #19451 depends on both so putting this one into stack was the only way to unblock myself working on #19451.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
As Martin mentioned [here](#19327 (comment)) makes sense to have the reorg handling be atomic. In this PR I tackle that. Note that this PR doesn't need to be in stack with #19443 but #19451 depends on both so putting this one into stack was the only way to unblock myself working on #19451.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes F-115
We have not yet handled reorgs in
PrivateEventStore. In this PR I tackle that.