refactor: atomic reorg handling #19364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
benesjan
commented
Jan 6, 2026
| // Update the header to the last block. | ||
| const newHeader = await this.node.getBlockHeader(event.block.number); | ||
| if (!newHeader) { | ||
| this.log.error(`Block header not found for block number ${event.block.number} during chain prune`); |
Contributor
Author
There was a problem hiding this comment.
Just logging out an error here if the new header is not found seemed incorrect as this would result in an inconsistent PXE state. For this reason I now throw an error here.
mverzilli
reviewed
Jan 7, 2026
benesjan
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
3ab2740 to
cefb7ca
Compare
benesjan
commented
Jan 7, 2026
benesjan
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
cefb7ca to
eba9c04
Compare
benesjan
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
eba9c04 to
e5f9c22
Compare
benesjan
changed the base branch from
graphite-base/19364
to
01-08-refactor_dropping_notehashleafindexmap
mverzilli
approved these changes
Jan 12, 2026
Contributor
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
LGTM, just consider using some Promise.all where possible/sensible
AztecBot
force-pushed
the
01-08-refactor_dropping_notehashleafindexmap
branch
2 times, most recently
from
83a369a to
1e1c8b8
Compare
nventuro
approved these changes
Jan 12, 2026
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
Approving to unblock, but you should probably address my feedback. Thanks!
yarn-project/stdlib/src/kernel/hints/build_note_hash_read_request_hints.ts
Show resolved
Hide resolved
Base automatically changed from
01-08-refactor_dropping_notehashleafindexmap
to
next
January 12, 2026 14:15
benesjan
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
e5f9c22 to
44d8dd8
Compare
benesjan
added
the
ci-no-fail-fast
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
1a8468f to
a61be37
Compare
As Martin mentioned [here](#19327 (comment)) makes sense to have the reorg handling be atomic. In this PR I tackle that. Note that this PR doesn't need to be in stack with #19443 but #19451 depends on both so putting this one into stack was the only way to unblock myself working on #19451.
AztecBot
force-pushed
the
01-06-refactor_atomic_reorg_handling
branch
from
a61be37 to
911b2b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Martin mentioned here makes sense to have the reorg handling be atomic. In this PR I tackle that.
Note that this PR doesn't need to be in stack with #19443 but #19451 depends on both so putting this one into stack was the only way to unblock myself working on #19451.