Skip to content

Conversation

@ducky64
Copy link
Collaborator

@ducky64 ducky64 commented Oct 25, 2025

This fixes cases where there is a dot in the dimensions and allows smaller 6.3x7.7mm caps to be parsed.
... and rebaseline the reference netlists

@ducky64 ducky64 requested a review from Copilot October 25, 2025 06:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes JLC electrolytic capacitor parsing to handle dots in dimensions and support smaller 6.3x7.7mm packages. The fix updates the regex pattern to avoid matching dimension specifications that are part of longer numeric strings, and regenerates reference netlists with the newly parsed smaller capacitors.

  • Updated regex pattern in JlcAluminumCapacitor to properly parse dimensions with dots
  • Replaced larger 8x10mm capacitors with smaller 6.3x7.7mm variants in example projects
  • Regenerated coordinate data and netlists for affected example boards

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
edg/parts/JlcElectrolyticCapacitor.py Modified regex to add negative lookahead for digit/dot before dimensions
examples/UsbSourceMeasure/UsbSourceMeasure.svgpcb.js Updated component positions and changed C1 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7
examples/UsbSourceMeasure/UsbSourceMeasure.net Updated C1 footprint and part metadata to reflect new 6.3x7.7mm capacitor
examples/IotRollerBlinds/IotRollerBlinds.svgpcb.js Updated component positions and changed BC10 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7
examples/IotRollerBlinds/IotRollerBlinds.net Updated BC10 footprint and part metadata to reflect new 6.3x7.7mm capacitor
examples/IotCurtainCrawler/IotCurtainCrawler.svgpcb.js Updated component positions and changed RC14 footprint from CP_Elec_8x10 to CP_Elec_6_3x7_7
examples/IotCurtainCrawler/IotCurtainCrawler.net Updated RC14 footprint and part metadata to reflect new 6.3x7.7mm capacitor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ducky64 ducky64 merged commit 29fef8f into master Oct 25, 2025
12 checks passed
@ducky64 ducky64 deleted the jlcelectrolyticfix branch October 25, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants