Skip to content

Fix JLC electrolytic cap parsing #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ducky64 merged 2 commits into from
Oct 25, 2025
Merged

Fix JLC electrolytic cap parsing #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1450e5
fix parsing and rebaseline
ducky64 Oct 25, 2025
0f49c98
Update JlcElectrolyticCapacitor.py
ducky64 Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion edg/parts/JlcElectrolyticCapacitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@

class JlcAluminumCapacitor(PartsTableSelectorFootprint, JlcTableSelector, TableCapacitor, AluminumCapacitor):
DESCRIPTION_PARSERS: List[DescriptionParser] = [
(re.compile(".* (\S+F).* (\S+V).* (±\S+%).*([\d\.]+x[\d\.]+)mm Aluminum Electrolytic Capacitors.*"),
# the negative match prevents the dimension substring from partially eaten
(re.compile(".* (\S+F).* (\S+V).* (±\S+%).*[^\d\.]([\d\.]+x[\d\.]+)mm Aluminum Electrolytic Capacitors.*"),
lambda match: { # discard the HF impedance parameter
TableCapacitor.NOMINAL_CAPACITANCE: PartParserUtil.parse_value(match.group(1), 'F'),
TableCapacitor.CAPACITANCE: PartParserUtil.parse_abs_tolerance(
Expand Down
6 changes: 3 additions & 3 deletions examples/IotCurtainCrawler/IotCurtainCrawler.net
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,14 +578,14 @@
(tstamps "0b6902a7"))
(comp (ref "RC14")
(value "drv.vm_cap1")
(footprint "Capacitor_SMD:CP_Elec_8x10")
(footprint "Capacitor_SMD:CP_Elec_6.3x7.7")
(property (name "Sheetname") (value "drv"))
(property (name "Sheetfile") (value "edg.parts.MotorDriver_Drv8870.Drv8870"))
(property (name "edg_path") (value "drv.vm_cap1.cap"))
(property (name "edg_short_path") (value "drv.vm_cap1"))
(property (name "edg_refdes") (value "RC14"))
(property (name "edg_part") (value "VEJ470M1JTR-0810 (Lelon)"))
(property (name "edg_value") (value "2000hrs@105℃ -45℃~+105℃ 47uF 10mm 63V 8mm ±20% SMD,8x10mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(property (name "edg_part") (value "RT1H470M0607 (ROQANG)"))
(property (name "edg_value") (value "-40℃~+105℃ 2000hrs@105℃ 47uF 7.7mm 50V 6.3mm ±20% SMD,6.3x7.7mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(sheetpath (names "/drv/") (tstamps "/0289014d/"))
(tstamps "0b6a02a8"))
(comp (ref "RR11")
Expand Down
10 changes: 5 additions & 5 deletions examples/IotCurtainCrawler/IotCurtainCrawler.svgpcb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,22 +232,22 @@ const RJ5 = board.add(Molex_PicoBlade_53398_0271_1x02_1MP_P1_25mm_Vertical, {
})
// drv.ic
const RU6 = board.add(HSOP_8_1EP_3_9x4_9mm_P1_27mm_EP2_41x3_1mm, {
translate: pt(1.740, 0.492), rotate: 0,
translate: pt(1.740, 0.425), rotate: 0,
id: 'RU6'
})
// drv.vm_cap0.cap
const RC13 = board.add(C_0603_1608Metric, {
translate: pt(2.202, 0.415), rotate: 0,
translate: pt(1.983, 0.475), rotate: 0,
id: 'RC13'
})
// drv.vm_cap1.cap
const RC14 = board.add(CP_Elec_8x10, {
translate: pt(1.811, 0.173), rotate: 0,
const RC14 = board.add(CP_Elec_6_3x7_7, {
translate: pt(1.780, 0.140), rotate: 0,
id: 'RC14'
})
// drv.isen_res.res
const RR11 = board.add(R_1206_3216Metric, {
translate: pt(2.015, 0.430), rotate: 0,
translate: pt(2.015, 0.363), rotate: 0,
id: 'RR11'
})

Expand Down
6 changes: 3 additions & 3 deletions examples/IotRollerBlinds/IotRollerBlinds.net
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,14 +446,14 @@
(tstamps "0b6902a7"))
(comp (ref "BC10")
(value "drv.vm_cap1")
(footprint "Capacitor_SMD:CP_Elec_8x10")
(footprint "Capacitor_SMD:CP_Elec_6.3x7.7")
(property (name "Sheetname") (value "drv"))
(property (name "Sheetfile") (value "edg.parts.MotorDriver_Drv8870.Drv8870"))
(property (name "edg_path") (value "drv.vm_cap1.cap"))
(property (name "edg_short_path") (value "drv.vm_cap1"))
(property (name "edg_refdes") (value "BC10"))
(property (name "edg_part") (value "VEJ470M1JTR-0810 (Lelon)"))
(property (name "edg_value") (value "2000hrs@105℃ -45℃~+105℃ 47uF 10mm 63V 8mm ±20% SMD,8x10mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(property (name "edg_part") (value "RT1H470M0607 (ROQANG)"))
(property (name "edg_value") (value "-40℃~+105℃ 2000hrs@105℃ 47uF 7.7mm 50V 6.3mm ±20% SMD,6.3x7.7mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(sheetpath (names "/drv/") (tstamps "/0289014d/"))
(tstamps "0b6a02a8"))
(comp (ref "BR10")
Expand Down
10 changes: 5 additions & 5 deletions examples/IotRollerBlinds/IotRollerBlinds.svgpcb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,22 +177,22 @@ const BJ5 = board.add(JST_SH_SM04B_SRSS_TB_1x04_1MP_P1_00mm_Horizontal, {
})
// drv.ic
const BU3 = board.add(HSOP_8_1EP_3_9x4_9mm_P1_27mm_EP2_41x3_1mm, {
translate: pt(1.740, 0.492), rotate: 0,
translate: pt(1.740, 0.425), rotate: 0,
id: 'BU3'
})
// drv.vm_cap0.cap
const BC9 = board.add(C_0603_1608Metric, {
translate: pt(2.202, 0.415), rotate: 0,
translate: pt(1.983, 0.475), rotate: 0,
id: 'BC9'
})
// drv.vm_cap1.cap
const BC10 = board.add(CP_Elec_8x10, {
translate: pt(1.811, 0.173), rotate: 0,
const BC10 = board.add(CP_Elec_6_3x7_7, {
translate: pt(1.780, 0.140), rotate: 0,
id: 'BC10'
})
// drv.isen_res.res
const BR10 = board.add(R_1206_3216Metric, {
translate: pt(2.015, 0.430), rotate: 0,
translate: pt(2.015, 0.363), rotate: 0,
id: 'BR10'
})

Expand Down
6 changes: 3 additions & 3 deletions examples/UsbSourceMeasure/UsbSourceMeasure.net
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@
(tstamps "12ed03cf"))
(comp (ref "C1")
(value "cap_vusb")
(footprint "Capacitor_SMD:CP_Elec_8x10")
(footprint "Capacitor_SMD:CP_Elec_6.3x7.7")
(property (name "Sheetname") (value ""))
(property (name "Sheetfile") (value ""))
(property (name "edg_path") (value "cap_vusb.cap"))
(property (name "edg_short_path") (value "cap_vusb"))
(property (name "edg_refdes") (value "C1"))
(property (name "edg_part") (value "VEJ101M1HTR-0810 (Lelon)"))
(property (name "edg_value") (value "2000hrs@105℃ -45℃~+105℃ 100uF 10mm 50V 8mm ±20% SMD,8x10mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(property (name "edg_part") (value "EEEFTH101XAP (PANASONIC)"))
(property (name "edg_value") (value "-45℃~+105℃ 2000hrs@105℃ 100uF 7.7mm 50V 6.3mm ±20% SMD,6.3x7.7mm Aluminum Electrolytic Capacitors - SMD ROHS"))
(sheetpath (names "/") (tstamps "/"))
(tstamps "0ec10354"))
(comp (ref "D1")
Expand Down
Loading