Skip to content

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Aug 19, 2025

Description

Story: BI-2193 - Improve/Correct Sub-Entity Tabular View

For ease of retrieving and displaying top level exp unit id in the sub-entity dataset view, the top level is exp unit id is now stored on creation of sub entity observation units in the additional info.

Dependencies

bi-web: feature/BI-2193

Testing

see bi-web

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 marked this pull request as ready for review August 20, 2025 22:31
@HMS17 HMS17 requested review from dmeidlin and mlm483 August 20, 2025 22:31
@HMS17 HMS17 assigned dmeidlin and unassigned dmeidlin Aug 20, 2025
@HMS17 HMS17 requested review from nickpalladino and removed request for dmeidlin August 25, 2025 17:20
position.setObservationLevelRelationships(levelRelationships);

observationUnit.putAdditionalInfoItem(BrAPIAdditionalInfoFields.EXP_UNIT_ID, expUnit.getObservationUnitName());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be worth standardizing how the level relationships are stored for the ExpUnit and SubObsUnit. The subObsUnit level code is set like this:

level.setLevelCode(Utilities.appendProgramKey(subUnitId, program.getKey(), seqVal));

The ExpUnit level is set like this:

expUnitLevel.setLevelCode(Utilities.appendProgramKey(expUnitUUID, program.getKey(), seqVal));

If they both stored the unitID in the level code I think you could use that instead of adding an additionalInfo field for it. It would be slightly more difficult to work with, wondering your thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok merging this and moving work related to comment to a new card

@nickpalladino nickpalladino self-requested a review November 20, 2025 15:09
@nickpalladino nickpalladino merged commit a638255 into develop Nov 25, 2025
@nickpalladino nickpalladino deleted the feature/BI-2193 branch November 25, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants