Skip to content

[BI-2193] Improve/Correct Sub-Entity Tabular View #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickpalladino merged 2 commits into from
Nov 25, 2025
Merged

[BI-2193] Improve/Correct Sub-Entity Tabular View #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c6bdd6
[BI-2193] Improve/Correct Sub-Entity Tabular View
HMS17 Aug 19, 2025
1dee565
Merge branch 'develop' into feature/BI-2193
HMS17 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/breedinginsight/brapi/v2/constants/BrAPIAdditionalInfoFields.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,5 @@ public final class BrAPIAdditionalInfoFields {
public static final String OBS_UNIT_ID = "obsUnitID";
public static final String GERMPLASM_NAME = "germplasmName";
public static final String SUBMISSION_NAME = "submissionName";
public static final String EXP_UNIT_ID = "expUnitID";
}
2 changes: 2 additions & 0 deletions src/main/java/org/breedinginsight/brapi/v2/services/BrAPITrialService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,8 @@ public BrAPIObservationUnit createSubObservationUnit(
levelRelationships.add(expUnitLevel);
position.setObservationLevelRelationships(levelRelationships);

observationUnit.putAdditionalInfoItem(BrAPIAdditionalInfoFields.EXP_UNIT_ID, expUnit.getObservationUnitName());

Copy link
Member

@nickpalladino nickpalladino Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be worth standardizing how the level relationships are stored for the ExpUnit and SubObsUnit. The subObsUnit level code is set like this:

level.setLevelCode(Utilities.appendProgramKey(subUnitId, program.getKey(), seqVal));

The ExpUnit level is set like this:

expUnitLevel.setLevelCode(Utilities.appendProgramKey(expUnitUUID, program.getKey(), seqVal));

If they both stored the unitID in the level code I think you could use that instead of adding an additionalInfo field for it. It would be slightly more difficult to work with, wondering your thoughts?

Copy link
Member

@nickpalladino nickpalladino Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok merging this and moving work related to comment to a new card

// Set ObservationUnitPosition.
observationUnit.setObservationUnitPosition(position);

Expand Down