BI-2288 - GitHub Improvements #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added architecture info and DeltaBreed branding
mlm483
requested review from
a team,
HMS17 and
dmeidlin
and removed request for
a team
HMS17
approved these changes
Dec 11, 2024
dmeidlin
requested changes
Jan 8, 2025
Contributor
dmeidlin
left a comment
dmeidlin
left a comment
There was a problem hiding this comment.
In the architecture diagram, the BrAPI arrow between Fieldbook and BI-API needs to be reversed to be consistent with the other two arrows for BI-WEB and breedinginsight.net/brapi/v2, implying that all three arrows represent requests/responses in which BI-API is the server and the others are clients.
Contributor
Author
@dmeidlin I updated the diagram to make it clear that Field Book is the client and bi-api is the server. |
dmeidlin
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Story: https://breedinginsight.atlassian.net/browse/BI-2288
I added architecture info and DeltaBreed branding to README.md with the goal of making the repository more approachable.