fix(providers): handle python-build-standalone on Windows #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python-build-standalone archives extract with a python/ subdirectory on all platforms, including Windows. Previously, the code assumed Windows would use the embeddable package format (files in root), causing the shim to fail to find the Python executable after installation. This change removes the Windows-specific case in determineSourceDir() and lets all platforms use the same logic: check for python/ subdirectory first, then fall back to the extract root for older embeddable packages.
CalvinAllen
deleted the
fix/providers/python-windows-directory-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
determineSourceDir()that assumed embeddable package formatpython/subdirectory on all platforms including WindowsProblem
The Python integration test on Windows was failing with:
The code was extracting the archive correctly, but then looking for
python.exein the wrong location because it skipped thepython/subdirectory detection on Windows.Test plan
Fixes integration test failure from https://github.com/dtvem/dtvem/actions/runs/20272683524