Skip to content

fix(providers): handle python-build-standalone on Windows #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CalvinAllen merged 1 commit into from
Dec 16, 2025
Merged

fix(providers): handle python-build-standalone on Windows #162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/runtimes/python/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,14 @@ func (p *Provider) downloadAndExtract(version, downloadURL, archiveName string)

// determineSourceDir determines the source directory from extracted archive
func determineSourceDir(extractDir string) string {
if goruntime.GOOS == constants.OSWindows {
// Windows embeddable: files are in extractDir root
return extractDir
}

// Unix python-build-standalone: files are in python/ subdirectory
// python-build-standalone: files are in python/ subdirectory (all platforms)
pythonSubdir := filepath.Join(extractDir, "python")
if _, err := os.Stat(pythonSubdir); err == nil {
return pythonSubdir
}

// Fallback: use extractDir if python/ doesn't exist
// (e.g., Windows embeddable packages from python.org have files in root)
return extractDir
}

Expand Down Expand Up @@ -384,10 +380,10 @@ func (p *Provider) ExecutablePath(version string) (string, error) {
// Determine executable name and path based on platform
var pythonPath string
if goruntime.GOOS == constants.OSWindows {
// Windows embeddable package has python.exe in root
// Windows: python.exe is in the installation root
pythonPath = filepath.Join(installPath, "python.exe")
} else {
// Unix has python in bin/
// Unix: python is in bin/ subdirectory
pythonPath = filepath.Join(installPath, "bin", "python")
}

Expand Down