Skip to content

Conversation

@AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Nov 24, 2025

What Does This Do

This PR bumps Spotbugs Gradle plugin to the most recent version 6.4.7 to this day (from 5.0.14).
And require a JDK 21 to run.

Important

This version of Spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.

Motivation

Latest tools provide more value.

Additional notes

Follow-up of this work

bric3 and others added 27 commits October 14, 2025 11:23
…internal-api

Also this forces JDK 11 to be the minimum.
# Conflicts:
#	communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java
#	utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
# Conflicts:
#	gradle/libs.versions.toml
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Nov 24, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added tag: do not merge Do not merge changes comp: tooling Build & Tooling labels Nov 24, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners December 1, 2025 16:05
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from randomanderson and shatzi and removed request for a team December 1, 2025 16:05
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the title Replaced code changes with @SuppressFBWarnings annotations. Bump spotbugs gradle plugin to 6.4.7 Dec 1, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD changed the base branch from bdu/spotbugs-bump-need-jdk11-min to master December 1, 2025 23:23
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners December 1, 2025 23:23
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit 1c2d839 into master Dec 2, 2025
543 of 544 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/spotbugs-base branch December 2, 2025 15:19
@github-actions github-actions bot added this to the 1.57.0 milestone Dec 2, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD removed the tag: do not merge Do not merge changes label Dec 2, 2025
AlexeyKuznetsov-DD added a commit that referenced this pull request Dec 2, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added the tag: no release notes Changes to exclude from release notes label Dec 2, 2025
AlexeyKuznetsov-DD added a commit that referenced this pull request Dec 2, 2025
bric3 added a commit that referenced this pull request Dec 3, 2025
bric3 added a commit that referenced this pull request Dec 3, 2025
* Revert "Revert "Bump spotbugs gradle plugin to 6.4.7 (#10025)" (#10067)"

This reverts commit c714e59.

* fix: Ignore tests failing on Oracle JDK 1.8 (#10065)

Those tests can be ignored as they are not specific to Oracle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants