-
Notifications
You must be signed in to change notification settings - Fork 323
Re-apply "Bump spotbugs gradle plugin to 6.4.7 (#10025)" #10074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051965
Total [baseline] (10.774 s) : 0, 10773724
Agent [candidate] (1.054 s) : 0, 1053784
Total [candidate] (10.837 s) : 0, 10837014
section appsec
Agent [baseline] (1.229 s) : 0, 1228736
Total [baseline] (10.876 s) : 0, 10876355
Agent [candidate] (1.228 s) : 0, 1228495
Total [candidate] (10.924 s) : 0, 10923693
section iast
Agent [baseline] (1.192 s) : 0, 1191806
Total [baseline] (11.174 s) : 0, 11173700
Agent [candidate] (1.194 s) : 0, 1194195
Total [candidate] (11.218 s) : 0, 11218400
section profiling
Agent [baseline] (1.204 s) : 0, 1203759
Total [baseline] (10.896 s) : 0, 10895988
Agent [candidate] (1.195 s) : 0, 1194953
Total [candidate] (10.914 s) : 0, 10914372
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (706.808 ms) : 0, 706808
BytebuddyAgent [candidate] (708.469 ms) : 0, 708469
GlobalTracer [baseline] (249.201 ms) : 0, 249201
GlobalTracer [candidate] (249.007 ms) : 0, 249007
AppSec [baseline] (31.963 ms) : 0, 31963
AppSec [candidate] (32.356 ms) : 0, 32356
Debugger [baseline] (6.394 ms) : 0, 6394
Debugger [candidate] (6.47 ms) : 0, 6470
Remote Config [baseline] (672.325 µs) : 0, 672
Remote Config [candidate] (677.243 µs) : 0, 677
Telemetry [baseline] (16.437 ms) : 0, 16437
Telemetry [candidate] (14.77 ms) : 0, 14770
Flare Poller [baseline] (4.169 ms) : 0, 4169
Flare Poller [candidate] (5.585 ms) : 0, 5585
section appsec
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (731.578 ms) : 0, 731578
BytebuddyAgent [candidate] (731.923 ms) : 0, 731923
GlobalTracer [baseline] (241.442 ms) : 0, 241442
GlobalTracer [candidate] (241.565 ms) : 0, 241565
IAST [baseline] (24.803 ms) : 0, 24803
IAST [candidate] (24.766 ms) : 0, 24766
AppSec [baseline] (175.239 ms) : 0, 175239
AppSec [candidate] (174.795 ms) : 0, 174795
Debugger [baseline] (6.332 ms) : 0, 6332
Debugger [candidate] (6.25 ms) : 0, 6250
Remote Config [baseline] (697.122 µs) : 0, 697
Remote Config [candidate] (679.35 µs) : 0, 679
Telemetry [baseline] (8.154 ms) : 0, 8154
Telemetry [candidate] (8.114 ms) : 0, 8114
Flare Poller [baseline] (3.992 ms) : 0, 3992
Flare Poller [candidate] (3.917 ms) : 0, 3917
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.496 ms) : 0, 1496
BytebuddyAgent [baseline] (830.671 ms) : 0, 830671
BytebuddyAgent [candidate] (831.812 ms) : 0, 831812
GlobalTracer [baseline] (237.921 ms) : 0, 237921
GlobalTracer [candidate] (238.758 ms) : 0, 238758
IAST [baseline] (30.0 ms) : 0, 30000
IAST [candidate] (31.824 ms) : 0, 31824
AppSec [baseline] (31.405 ms) : 0, 31405
AppSec [candidate] (29.763 ms) : 0, 29763
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.149 ms) : 0, 6149
Remote Config [baseline] (616.86 µs) : 0, 617
Remote Config [candidate] (623.341 µs) : 0, 623
Telemetry [baseline] (7.96 ms) : 0, 7960
Telemetry [candidate] (8.014 ms) : 0, 8014
Flare Poller [baseline] (10.784 ms) : 0, 10784
Flare Poller [candidate] (10.855 ms) : 0, 10855
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (737.795 ms) : 0, 737795
BytebuddyAgent [candidate] (731.31 ms) : 0, 731310
GlobalTracer [baseline] (223.368 ms) : 0, 223368
GlobalTracer [candidate] (221.919 ms) : 0, 221919
AppSec [baseline] (32.426 ms) : 0, 32426
AppSec [candidate] (32.147 ms) : 0, 32147
Debugger [baseline] (7.649 ms) : 0, 7649
Debugger [candidate] (6.775 ms) : 0, 6775
Remote Config [baseline] (680.247 µs) : 0, 680
Remote Config [candidate] (676.66 µs) : 0, 677
Telemetry [baseline] (15.569 ms) : 0, 15569
Telemetry [candidate] (16.449 ms) : 0, 16449
Flare Poller [baseline] (4.189 ms) : 0, 4189
Flare Poller [candidate] (4.147 ms) : 0, 4147
ProfilingAgent [baseline] (110.899 ms) : 0, 110899
ProfilingAgent [candidate] (110.708 ms) : 0, 110708
Profiling [baseline] (111.548 ms) : 0, 111548
Profiling [candidate] (111.34 ms) : 0, 111340
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049838
Total [baseline] (8.676 s) : 0, 8675785
Agent [candidate] (1.062 s) : 0, 1062308
Total [candidate] (8.737 s) : 0, 8736548
section iast
Agent [baseline] (1.195 s) : 0, 1195095
Total [baseline] (9.335 s) : 0, 9335365
Agent [candidate] (1.205 s) : 0, 1205014
Total [candidate] (9.293 s) : 0, 9293230
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.499 ms) : 0, 1499
BytebuddyAgent [baseline] (705.829 ms) : 0, 705829
BytebuddyAgent [candidate] (715.008 ms) : 0, 715008
GlobalTracer [baseline] (248.327 ms) : 0, 248327
GlobalTracer [candidate] (250.681 ms) : 0, 250681
AppSec [baseline] (31.916 ms) : 0, 31916
AppSec [candidate] (32.245 ms) : 0, 32245
Debugger [baseline] (6.348 ms) : 0, 6348
Debugger [candidate] (6.498 ms) : 0, 6498
Remote Config [baseline] (672.081 µs) : 0, 672
Remote Config [candidate] (683.7 µs) : 0, 684
Telemetry [baseline] (15.549 ms) : 0, 15549
Telemetry [candidate] (15.613 ms) : 0, 15613
Flare Poller [baseline] (4.878 ms) : 0, 4878
Flare Poller [candidate] (4.977 ms) : 0, 4977
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.5 ms) : 0, 1500
BytebuddyAgent [baseline] (830.965 ms) : 0, 830965
BytebuddyAgent [candidate] (841.691 ms) : 0, 841691
GlobalTracer [baseline] (238.963 ms) : 0, 238963
GlobalTracer [candidate] (239.145 ms) : 0, 239145
IAST [baseline] (28.901 ms) : 0, 28901
IAST [candidate] (33.095 ms) : 0, 33095
AppSec [baseline] (33.306 ms) : 0, 33306
AppSec [candidate] (28.87 ms) : 0, 28870
Debugger [baseline] (6.371 ms) : 0, 6371
Debugger [candidate] (6.102 ms) : 0, 6102
Remote Config [baseline] (626.171 µs) : 0, 626
Remote Config [candidate] (609.571 µs) : 0, 610
Telemetry [baseline] (8.23 ms) : 0, 8230
Telemetry [candidate] (7.934 ms) : 0, 7934
Flare Poller [baseline] (11.145 ms) : 0, 11145
Flare Poller [candidate] (10.925 ms) : 0, 10925
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section baseline
no_agent (1.216 ms) : 1204, 1227
. : milestone, 1216,
iast (3.271 ms) : 3229, 3312
. : milestone, 3271,
iast_FULL (5.981 ms) : 5919, 6042
. : milestone, 5981,
iast_GLOBAL (3.499 ms) : 3446, 3551
. : milestone, 3499,
profiling (2.0 ms) : 1983, 2017
. : milestone, 2000,
tracing (1.82 ms) : 1804, 1836
. : milestone, 1820,
section candidate
no_agent (1.195 ms) : 1184, 1207
. : milestone, 1195,
iast (3.306 ms) : 3264, 3349
. : milestone, 3306,
iast_FULL (5.978 ms) : 5917, 6040
. : milestone, 5978,
iast_GLOBAL (3.488 ms) : 3434, 3543
. : milestone, 3488,
profiling (1.962 ms) : 1945, 1979
. : milestone, 1962,
tracing (1.828 ms) : 1814, 1843
. : milestone, 1828,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section baseline
no_agent (19.471 ms) : 19268, 19675
. : milestone, 19471,
appsec (18.396 ms) : 18205, 18587
. : milestone, 18396,
code_origins (17.534 ms) : 17364, 17705
. : milestone, 17534,
iast (17.644 ms) : 17468, 17820
. : milestone, 17644,
profiling (18.56 ms) : 18369, 18751
. : milestone, 18560,
tracing (18.547 ms) : 18363, 18731
. : milestone, 18547,
section candidate
no_agent (19.001 ms) : 18808, 19193
. : milestone, 19001,
appsec (19.663 ms) : 19458, 19867
. : milestone, 19663,
code_origins (18.695 ms) : 18507, 18884
. : milestone, 18695,
iast (17.401 ms) : 17230, 17572
. : milestone, 17401,
profiling (18.833 ms) : 18642, 19023
. : milestone, 18833,
tracing (18.676 ms) : 18490, 18862
. : milestone, 18676,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.71 ms) : 3493, 3927
. : milestone, 3710,
iast (2.218 ms) : 2154, 2283
. : milestone, 2218,
iast_GLOBAL (2.27 ms) : 2205, 2336
. : milestone, 2270,
profiling (2.091 ms) : 2037, 2145
. : milestone, 2091,
tracing (2.06 ms) : 2009, 2111
. : milestone, 2060,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.66 ms) : 3445, 3875
. : milestone, 3660,
iast (2.217 ms) : 2152, 2282
. : milestone, 2217,
iast_GLOBAL (2.273 ms) : 2208, 2338
. : milestone, 2273,
profiling (2.105 ms) : 2051, 2159
. : milestone, 2105,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f978bf472c, baseline=1.57.0-SNAPSHOT~00864b34af
dateFormat X
axisFormat %s
section baseline
no_agent (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
appsec (14.479 s) : 14479000, 14479000
. : milestone, 14479000,
iast (18.439 s) : 18439000, 18439000
. : milestone, 18439000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (14.595 s) : 14595000, 14595000
. : milestone, 14595000,
tracing (14.633 s) : 14633000, 14633000
. : milestone, 14633000,
section candidate
no_agent (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
appsec (14.734 s) : 14734000, 14734000
. : milestone, 14734000,
iast (18.421 s) : 18421000, 18421000
. : milestone, 18421000,
iast_GLOBAL (17.827 s) : 17827000, 17827000
. : milestone, 17827000,
profiling (14.779 s) : 14779000, 14779000
. : milestone, 14779000,
tracing (14.659 s) : 14659000, 14659000
. : milestone, 14659000,
|
Those tests can be ignored as they are not specific to Oracle.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
The #10025 PR was originally reverted due to an issue, that we know is caused by a non fixed issue in Oracle JDK.
Includes the workaround in
MalformedParametersException#10065 (merged)Reverts the revert in #10067 (so actually re-apply #10025)
Additional notes
Follow-up of this work