-
Notifications
You must be signed in to change notification settings - Fork 323
Workaround for Oracle 1.8 MalformedParametersException
#10065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for Oracle 1.8 MalformedParametersException
#10065
Conversation
MalformedParametersException
815a59a to
4ce108a
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054198
Total [baseline] (10.806 s) : 0, 10805514
Agent [candidate] (1.054 s) : 0, 1054467
Total [candidate] (10.784 s) : 0, 10784156
section appsec
Agent [baseline] (1.232 s) : 0, 1232417
Total [baseline] (10.95 s) : 0, 10950473
Agent [candidate] (1.229 s) : 0, 1228550
Total [candidate] (10.891 s) : 0, 10891302
section iast
Agent [baseline] (1.202 s) : 0, 1201736
Total [baseline] (11.249 s) : 0, 11248553
Agent [candidate] (1.194 s) : 0, 1193956
Total [candidate] (11.182 s) : 0, 11182284
section profiling
Agent [baseline] (1.209 s) : 0, 1208843
Total [baseline] (10.935 s) : 0, 10934999
Agent [candidate] (1.199 s) : 0, 1198555
Total [candidate] (10.982 s) : 0, 10982223
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (708.503 ms) : 0, 708503
BytebuddyAgent [candidate] (708.881 ms) : 0, 708881
GlobalTracer [baseline] (249.732 ms) : 0, 249732
GlobalTracer [candidate] (249.543 ms) : 0, 249543
AppSec [baseline] (32.025 ms) : 0, 32025
AppSec [candidate] (32.29 ms) : 0, 32290
Debugger [baseline] (6.387 ms) : 0, 6387
Debugger [candidate] (6.413 ms) : 0, 6413
Remote Config [baseline] (671.486 µs) : 0, 671
Remote Config [candidate] (686.232 µs) : 0, 686
Telemetry [baseline] (15.769 ms) : 0, 15769
Telemetry [candidate] (13.825 ms) : 0, 13825
Flare Poller [baseline] (4.81 ms) : 0, 4810
Flare Poller [candidate] (6.536 ms) : 0, 6536
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (733.161 ms) : 0, 733161
BytebuddyAgent [candidate] (732.632 ms) : 0, 732632
GlobalTracer [baseline] (243.081 ms) : 0, 243081
GlobalTracer [candidate] (241.325 ms) : 0, 241325
IAST [baseline] (25.061 ms) : 0, 25061
IAST [candidate] (24.889 ms) : 0, 24889
AppSec [baseline] (175.593 ms) : 0, 175593
AppSec [candidate] (174.488 ms) : 0, 174488
Debugger [baseline] (6.305 ms) : 0, 6305
Debugger [candidate] (6.241 ms) : 0, 6241
Remote Config [baseline] (688.346 µs) : 0, 688
Remote Config [candidate] (676.831 µs) : 0, 677
Telemetry [baseline] (8.08 ms) : 0, 8080
Telemetry [candidate] (7.987 ms) : 0, 7987
Flare Poller [baseline] (4.022 ms) : 0, 4022
Flare Poller [candidate] (3.934 ms) : 0, 3934
section iast
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (839.32 ms) : 0, 839320
BytebuddyAgent [candidate] (833.494 ms) : 0, 833494
GlobalTracer [baseline] (238.854 ms) : 0, 238854
GlobalTracer [candidate] (237.976 ms) : 0, 237976
IAST [baseline] (33.693 ms) : 0, 33693
IAST [candidate] (32.247 ms) : 0, 32247
AppSec [baseline] (28.06 ms) : 0, 28060
AppSec [candidate] (28.642 ms) : 0, 28642
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (608.993 µs) : 0, 609
Remote Config [candidate] (596.679 µs) : 0, 597
Telemetry [baseline] (7.963 ms) : 0, 7963
Telemetry [candidate] (7.875 ms) : 0, 7875
Flare Poller [baseline] (10.709 ms) : 0, 10709
Flare Poller [candidate] (10.777 ms) : 0, 10777
section profiling
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (741.119 ms) : 0, 741119
BytebuddyAgent [candidate] (734.864 ms) : 0, 734864
GlobalTracer [baseline] (223.782 ms) : 0, 223782
GlobalTracer [candidate] (222.413 ms) : 0, 222413
AppSec [baseline] (32.452 ms) : 0, 32452
AppSec [candidate] (32.221 ms) : 0, 32221
Debugger [baseline] (7.647 ms) : 0, 7647
Debugger [candidate] (7.515 ms) : 0, 7515
Remote Config [baseline] (681.521 µs) : 0, 682
Remote Config [candidate] (676.973 µs) : 0, 677
Telemetry [baseline] (15.587 ms) : 0, 15587
Telemetry [candidate] (15.492 ms) : 0, 15492
Flare Poller [baseline] (4.194 ms) : 0, 4194
Flare Poller [candidate] (4.131 ms) : 0, 4131
ProfilingAgent [baseline] (111.807 ms) : 0, 111807
ProfilingAgent [candidate] (110.513 ms) : 0, 110513
Profiling [baseline] (112.442 ms) : 0, 112442
Profiling [candidate] (111.155 ms) : 0, 111155
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056034
Total [baseline] (8.678 s) : 0, 8677502
Agent [candidate] (1.061 s) : 0, 1060521
Total [candidate] (8.642 s) : 0, 8641905
section iast
Agent [baseline] (1.206 s) : 0, 1206316
Total [baseline] (9.389 s) : 0, 9388922
Agent [candidate] (1.205 s) : 0, 1205453
Total [candidate] (9.341 s) : 0, 9340554
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.504 ms) : 0, 1504
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (710.412 ms) : 0, 710412
BytebuddyAgent [candidate] (712.898 ms) : 0, 712898
GlobalTracer [baseline] (249.555 ms) : 0, 249555
GlobalTracer [candidate] (251.151 ms) : 0, 251151
AppSec [baseline] (32.241 ms) : 0, 32241
AppSec [candidate] (32.58 ms) : 0, 32580
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.513 ms) : 0, 6513
Remote Config [baseline] (676.035 µs) : 0, 676
Remote Config [candidate] (674.9 µs) : 0, 675
Telemetry [baseline] (16.258 ms) : 0, 16258
Telemetry [candidate] (15.408 ms) : 0, 15408
Flare Poller [baseline] (4.103 ms) : 0, 4103
Flare Poller [candidate] (4.82 ms) : 0, 4820
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.488 ms) : 0, 1488
BytebuddyAgent [baseline] (841.161 ms) : 0, 841161
BytebuddyAgent [candidate] (841.088 ms) : 0, 841088
GlobalTracer [baseline] (240.361 ms) : 0, 240361
GlobalTracer [candidate] (240.498 ms) : 0, 240498
AppSec [baseline] (31.534 ms) : 0, 31534
AppSec [candidate] (27.369 ms) : 0, 27369
Debugger [baseline] (6.161 ms) : 0, 6161
Debugger [candidate] (6.065 ms) : 0, 6065
Remote Config [baseline] (622.345 µs) : 0, 622
Remote Config [candidate] (615.858 µs) : 0, 616
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (7.968 ms) : 0, 7968
Flare Poller [baseline] (10.933 ms) : 0, 10933
Flare Poller [candidate] (10.671 ms) : 0, 10671
IAST [baseline] (30.583 ms) : 0, 30583
IAST [candidate] (34.731 ms) : 0, 34731
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section baseline
no_agent (18.996 ms) : 18807, 19185
. : milestone, 18996,
appsec (18.644 ms) : 18453, 18835
. : milestone, 18644,
code_origins (17.748 ms) : 17576, 17921
. : milestone, 17748,
iast (18.661 ms) : 18471, 18851
. : milestone, 18661,
profiling (18.647 ms) : 18457, 18837
. : milestone, 18647,
tracing (17.663 ms) : 17485, 17840
. : milestone, 17663,
section candidate
no_agent (17.3 ms) : 17123, 17476
. : milestone, 17300,
appsec (18.759 ms) : 18568, 18950
. : milestone, 18759,
code_origins (17.945 ms) : 17761, 18129
. : milestone, 17945,
iast (17.774 ms) : 17596, 17951
. : milestone, 17774,
profiling (18.825 ms) : 18634, 19016
. : milestone, 18825,
tracing (17.993 ms) : 17815, 18171
. : milestone, 17993,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.257 ms) : 3212, 3302
. : milestone, 3257,
iast_FULL (5.795 ms) : 5738, 5852
. : milestone, 5795,
iast_GLOBAL (3.69 ms) : 3629, 3750
. : milestone, 3690,
profiling (2.172 ms) : 2153, 2192
. : milestone, 2172,
tracing (1.804 ms) : 1789, 1819
. : milestone, 1804,
section candidate
no_agent (1.189 ms) : 1177, 1200
. : milestone, 1189,
iast (3.249 ms) : 3203, 3295
. : milestone, 3249,
iast_FULL (5.772 ms) : 5713, 5830
. : milestone, 5772,
iast_GLOBAL (3.541 ms) : 3487, 3595
. : milestone, 3541,
profiling (1.933 ms) : 1916, 1949
. : milestone, 1933,
tracing (1.809 ms) : 1794, 1824
. : milestone, 1809,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (2.46 ms) : 2408, 2511
. : milestone, 2460,
iast (2.212 ms) : 2148, 2277
. : milestone, 2212,
iast_GLOBAL (2.261 ms) : 2195, 2326
. : milestone, 2261,
profiling (2.071 ms) : 2018, 2123
. : milestone, 2071,
tracing (2.048 ms) : 1997, 2100
. : milestone, 2048,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.469 ms) : 2417, 2521
. : milestone, 2469,
iast (2.217 ms) : 2153, 2282
. : milestone, 2217,
iast_GLOBAL (2.257 ms) : 2192, 2322
. : milestone, 2257,
profiling (2.073 ms) : 2021, 2126
. : milestone, 2073,
tracing (2.046 ms) : 1995, 2097
. : milestone, 2046,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~b897cd68a2, baseline=1.57.0-SNAPSHOT~077bcfba1e
dateFormat X
axisFormat %s
section baseline
no_agent (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
appsec (15.259 s) : 15259000, 15259000
. : milestone, 15259000,
iast (18.454 s) : 18454000, 18454000
. : milestone, 18454000,
iast_GLOBAL (17.756 s) : 17756000, 17756000
. : milestone, 17756000,
profiling (14.54 s) : 14540000, 14540000
. : milestone, 14540000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (14.717 s) : 14717000, 14717000
. : milestone, 14717000,
iast (18.46 s) : 18460000, 18460000
. : milestone, 18460000,
iast_GLOBAL (18.121 s) : 18121000, 18121000
. : milestone, 18121000,
profiling (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
tracing (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
|
9591417 to
0a72b8c
Compare
0a72b8c to
541579b
Compare
Those tests can be ignored as they are not specific to Oracle.
541579b to
b897cd6
Compare
|
💭 thought: About the possible workarounds:
This will also make the reflect API slower, in parts like the agent bootstrap initialization. |
What Does This Do
Ignores test failing on Oracle JDK 1.8 due to patch apparently not merged on Oracle JDK.
Fixes test for
MalformedParametersException#10065 that was reverted for this reasonMotivation
Oracle JDK 1.8u471 – the latest to this day – do not have the fix for JDK-8058322 that landed last year in jdk8u, while other OpenJDK 8 distribution have it.
This prevents test to work correctly when the code is compiled to Java 8 from a JDK21+ compiler. In this version the HotSpot JVM on Oracle 8 misread the parameter names and raises a
MalformedParametersExceptionwhen invoking the methodExecutable::getParameters.Full description here: https://github.com/bric3/malformed-parameters-oracle-8
Actual bug (fixed on OpenJDK not on Oracle JDK) : https://bugs.openjdk.org/browse/JDK-8058322
This to primarily impacts mocks (regardless of the test library), but it is not limited to that.
Possible workarounds
-parameterseverywhere, this however increases the size by 44 KiB, without added benefit for the customers.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]