-
Notifications
You must be signed in to change notification settings - Fork 323
Update io.opentelemetry.opentelemetry-api to 1.47.0 #9762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 701e1f3 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1020621
Total [baseline] (8.695 s) : 0, 8695413
Agent [candidate] (1.03 s) : 0, 1029540
Total [candidate] (8.702 s) : 0, 8701995
section iast
Agent [baseline] (1.153 s) : 0, 1152932
Total [baseline] (9.304 s) : 0, 9303678
Agent [candidate] (1.155 s) : 0, 1154667
Total [candidate] (9.301 s) : 0, 9300737
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (693.897 ms) : 0, 693897
BytebuddyAgent [candidate] (701.919 ms) : 0, 701919
GlobalTracer [baseline] (243.023 ms) : 0, 243023
GlobalTracer [candidate] (244.917 ms) : 0, 244917
AppSec [baseline] (32.615 ms) : 0, 32615
AppSec [candidate] (33.013 ms) : 0, 33013
Debugger [baseline] (6.485 ms) : 0, 6485
Debugger [candidate] (6.545 ms) : 0, 6545
Remote Config [baseline] (715.686 µs) : 0, 716
Remote Config [candidate] (723.539 µs) : 0, 724
Telemetry [baseline] (9.528 ms) : 0, 9528
Telemetry [candidate] (9.491 ms) : 0, 9491
Flare Poller [baseline] (11.769 ms) : 0, 11769
Flare Poller [candidate] (10.03 ms) : 0, 10030
section iast
crashtracking [baseline] (1.51 ms) : 0, 1510
crashtracking [candidate] (1.505 ms) : 0, 1505
BytebuddyAgent [baseline] (817.578 ms) : 0, 817578
BytebuddyAgent [candidate] (818.635 ms) : 0, 818635
GlobalTracer [baseline] (230.758 ms) : 0, 230758
GlobalTracer [candidate] (231.73 ms) : 0, 231730
IAST [baseline] (26.292 ms) : 0, 26292
IAST [candidate] (26.384 ms) : 0, 26384
AppSec [baseline] (35.398 ms) : 0, 35398
AppSec [candidate] (35.15 ms) : 0, 35150
Debugger [baseline] (6.175 ms) : 0, 6175
Debugger [candidate] (6.146 ms) : 0, 6146
Remote Config [baseline] (620.693 µs) : 0, 621
Remote Config [candidate] (610.406 µs) : 0, 610
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.73 ms) : 0, 8730
Flare Poller [baseline] (4.299 ms) : 0, 4299
Flare Poller [candidate] (4.159 ms) : 0, 4159
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016558
Total [baseline] (10.699 s) : 0, 10698628
Agent [candidate] (1.016 s) : 0, 1016363
Total [candidate] (10.649 s) : 0, 10649291
section appsec
Agent [baseline] (1.2 s) : 0, 1200185
Total [baseline] (11.066 s) : 0, 11065720
Agent [candidate] (1.195 s) : 0, 1194673
Total [candidate] (11.004 s) : 0, 11004350
section iast
Agent [baseline] (1.151 s) : 0, 1150553
Total [baseline] (11.036 s) : 0, 11035719
Agent [candidate] (1.151 s) : 0, 1151214
Total [candidate] (11.07 s) : 0, 11069521
section profiling
Agent [baseline] (1.167 s) : 0, 1166783
Total [baseline] (11.04 s) : 0, 11039563
Agent [candidate] (1.159 s) : 0, 1158864
Total [candidate] (11.026 s) : 0, 11026039
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (693.164 ms) : 0, 693164
BytebuddyAgent [candidate] (692.448 ms) : 0, 692448
GlobalTracer [baseline] (241.149 ms) : 0, 241149
GlobalTracer [candidate] (241.879 ms) : 0, 241879
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.194 ms) : 0, 32194
Debugger [baseline] (6.387 ms) : 0, 6387
Debugger [candidate] (6.397 ms) : 0, 6397
Remote Config [baseline] (707.882 µs) : 0, 708
Remote Config [candidate] (701.865 µs) : 0, 702
Telemetry [baseline] (9.332 ms) : 0, 9332
Telemetry [candidate] (9.36 ms) : 0, 9360
Flare Poller [baseline] (10.839 ms) : 0, 10839
Flare Poller [candidate] (10.789 ms) : 0, 10789
section appsec
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (722.473 ms) : 0, 722473
BytebuddyAgent [candidate] (717.551 ms) : 0, 717551
GlobalTracer [baseline] (234.375 ms) : 0, 234375
GlobalTracer [candidate] (235.002 ms) : 0, 235002
IAST [baseline] (24.807 ms) : 0, 24807
IAST [candidate] (24.87 ms) : 0, 24870
AppSec [baseline] (176.446 ms) : 0, 176446
AppSec [candidate] (175.515 ms) : 0, 175515
Debugger [baseline] (6.178 ms) : 0, 6178
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (647.623 µs) : 0, 648
Remote Config [candidate] (630.03 µs) : 0, 630
Telemetry [baseline] (8.539 ms) : 0, 8539
Telemetry [candidate] (8.553 ms) : 0, 8553
Flare Poller [baseline] (3.934 ms) : 0, 3934
Flare Poller [candidate] (3.877 ms) : 0, 3877
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (814.865 ms) : 0, 814865
BytebuddyAgent [candidate] (815.589 ms) : 0, 815589
GlobalTracer [baseline] (231.462 ms) : 0, 231462
GlobalTracer [candidate] (231.444 ms) : 0, 231444
IAST [baseline] (26.348 ms) : 0, 26348
IAST [candidate] (26.456 ms) : 0, 26456
AppSec [baseline] (35.236 ms) : 0, 35236
AppSec [candidate] (35.107 ms) : 0, 35107
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.089 ms) : 0, 6089
Remote Config [baseline] (617.071 µs) : 0, 617
Remote Config [candidate] (604.521 µs) : 0, 605
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.698 ms) : 0, 8698
Flare Poller [baseline] (4.251 ms) : 0, 4251
Flare Poller [candidate] (4.204 ms) : 0, 4204
section profiling
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (724.082 ms) : 0, 724082
BytebuddyAgent [candidate] (718.467 ms) : 0, 718467
GlobalTracer [baseline] (218.261 ms) : 0, 218261
GlobalTracer [candidate] (216.975 ms) : 0, 216975
AppSec [baseline] (32.694 ms) : 0, 32694
AppSec [candidate] (32.293 ms) : 0, 32293
Debugger [baseline] (6.6 ms) : 0, 6600
Debugger [candidate] (7.302 ms) : 0, 7302
Remote Config [baseline] (795.237 µs) : 0, 795
Remote Config [candidate] (786.538 µs) : 0, 787
Telemetry [baseline] (15.124 ms) : 0, 15124
Telemetry [candidate] (15.406 ms) : 0, 15406
Flare Poller [baseline] (4.875 ms) : 0, 4875
Flare Poller [candidate] (4.119 ms) : 0, 4119
ProfilingAgent [baseline] (108.804 ms) : 0, 108804
ProfilingAgent [candidate] (109.226 ms) : 0, 109226
Profiling [baseline] (110.557 ms) : 0, 110557
Profiling [candidate] (110.213 ms) : 0, 110213
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (4.185 ms) : 4138, 4232
. : milestone, 4185,
iast (10.143 ms) : 9971, 10315
. : milestone, 10143,
iast_FULL (13.787 ms) : 13511, 14063
. : milestone, 13787,
iast_GLOBAL (10.197 ms) : 10019, 10376
. : milestone, 10197,
profiling (8.897 ms) : 8764, 9031
. : milestone, 8897,
tracing (7.546 ms) : 7438, 7653
. : milestone, 7546,
section candidate
no_agent (4.356 ms) : 4303, 4409
. : milestone, 4356,
iast (10.157 ms) : 9973, 10340
. : milestone, 10157,
iast_FULL (13.854 ms) : 13582, 14125
. : milestone, 13854,
iast_GLOBAL (10.037 ms) : 9863, 10210
. : milestone, 10037,
profiling (9.298 ms) : 9141, 9456
. : milestone, 9298,
tracing (7.797 ms) : 7686, 7908
. : milestone, 7797,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (37.282 ms) : 36982, 37583
. : milestone, 37282,
appsec (49.92 ms) : 49477, 50362
. : milestone, 49920,
code_origins (44.278 ms) : 43899, 44657
. : milestone, 44278,
iast (46.294 ms) : 45898, 46691
. : milestone, 46294,
profiling (47.523 ms) : 47040, 48006
. : milestone, 47523,
tracing (44.472 ms) : 44075, 44868
. : milestone, 44472,
section candidate
no_agent (37.368 ms) : 37073, 37664
. : milestone, 37368,
appsec (49.665 ms) : 49228, 50102
. : milestone, 49665,
code_origins (44.917 ms) : 44529, 45305
. : milestone, 44917,
iast (44.099 ms) : 43727, 44470
. : milestone, 44099,
profiling (49.685 ms) : 49253, 50118
. : milestone, 49685,
tracing (43.594 ms) : 43205, 43982
. : milestone, 43594,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
appsec (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
iast (18.622 s) : 18622000, 18622000
. : milestone, 18622000,
iast_GLOBAL (17.907 s) : 17907000, 17907000
. : milestone, 17907000,
profiling (15.189 s) : 15189000, 15189000
. : milestone, 15189000,
tracing (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
section candidate
no_agent (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
appsec (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
iast (18.29 s) : 18290000, 18290000
. : milestone, 18290000,
iast_GLOBAL (18.172 s) : 18172000, 18172000
. : milestone, 18172000,
profiling (15.576 s) : 15576000, 15576000
. : milestone, 15576000,
tracing (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~701e1f3127, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.724 ms) : 3504, 3944
. : milestone, 3724,
iast (2.207 ms) : 2144, 2270
. : milestone, 2207,
iast_GLOBAL (2.253 ms) : 2189, 2316
. : milestone, 2253,
profiling (2.077 ms) : 2025, 2129
. : milestone, 2077,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.713 ms) : 3496, 3931
. : milestone, 3713,
iast (2.209 ms) : 2145, 2272
. : milestone, 2209,
iast_GLOBAL (2.272 ms) : 2208, 2337
. : milestone, 2272,
profiling (2.057 ms) : 2006, 2109
. : milestone, 2057,
tracing (2.022 ms) : 1973, 2071
. : milestone, 2022,
|
| dependencies { | ||
| // minimum OpenTelemetry API version this shim is compatible with | ||
| compileOnly group: 'io.opentelemetry', name: 'opentelemetry-api', version: '1.4.0' | ||
| compileOnly group: 'io.opentelemetry', name: 'opentelemetry-api', version: '1.47.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❔ question: Aren't we supposed to compile against the earliest version we support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to add metrics support - and the minimum version to target there (according to the agreed doc) is 1.47.0
Technically we could drop down to 1.38.0 which is when the double gauge type was introduced, but that could cause confusion when comparing with other languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another approach would be to have multiple shim modules (one for tracing, one for metrics) compiled against different minimum versions - but that also has risks, because then we'd need be careful about where those overlap.
TBH I think this is the pragmatic option - and we can still verify compatibility against various versions in smoke tests
What Does This Do
Bump the version of the
io.opentelemetry.opentelemetry-apidependency from 1.4.0 to 1.47.0.Motivation
1.47.0 is the minimum version to target according to our RFC for OpenTelemetry Metrics API support.
Additional Notes
Jira ticket: APMAPI-1671