Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dd-java-agent/agent-otel/otel-shim/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ minimumBranchCoverage = 0.0

dependencies {
// minimum OpenTelemetry API version this shim is compatible with
compileOnly group: 'io.opentelemetry', name: 'opentelemetry-api', version: '1.4.0'
compileOnly group: 'io.opentelemetry', name: 'opentelemetry-api', version: '1.47.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ question: ‏Aren't we supposed to compile against the earliest version we support?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to add metrics support - and the minimum version to target there (according to the agreed doc) is 1.47.0

Technically we could drop down to 1.38.0 which is when the double gauge type was introduced, but that could cause confusion when comparing with other languages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another approach would be to have multiple shim modules (one for tracing, one for metrics) compiled against different minimum versions - but that also has risks, because then we'd need be careful about where those overlap.

TBH I think this is the pragmatic option - and we can still verify compatibility against various versions in smoke tests


implementation project(':internal-api')
}
Loading