feat(prof): add I/O profiling for macOS#3648
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3648 +/- ##
==========================================
- Coverage 62.21% 62.11% -0.11%
==========================================
Files 141 141
Lines 13387 13387
Branches 1753 1753
==========================================
- Hits 8329 8315 -14
- Misses 4260 4273 +13
- Partials 798 799 +1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ profiler ]Benchmark execution time: 2026-02-18 06:38:51 Comparing candidate commit 6bac2fd in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 26 metrics, 7 unstable metrics. scenario:walk_stack/1
scenario:walk_stack/50
scenario:walk_stack/99
|
3368fe5 to
a83fd12
Compare
a83fd12 to
2aa2c4b
Compare
2aa2c4b to
e32fa5d
Compare
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
e32fa5d to
6bac2fd
Compare
morrisonlevi
left a comment
There was a problem hiding this comment.
I have some more reading to do to review the rest of it, but here's some review.
| // The libc crate deprecates Mach-O types in favor of the mach2 crate, but we only use a few | ||
| // types and don't want to add a dependency just for that. | ||
| #![allow(deprecated)] |
There was a problem hiding this comment.
Why? Is there some undesirable reason to have a macOS-only dependency on mach2?
There was a problem hiding this comment.
The main reason was to keep the dependency surface minimal and avoid extra target-specific dependency/lockfile "overhead" just for this "local-dev" feature. I wanted to keep things "contained", so that being said: there isn’t a functional blocker to using mach2. If you prefer, I can switch this file to mach2 and drop the #![allow(deprecated)]
Description
This PR:
mod.rsWhy support macOS I/O profiling?
AFAIK we might have a few customers running the profiler on macOS, but the real value is local testability for I/O profiling in our developer environment which is native macOS.
Reviewer checklist