Skip to content

Send response headers on meta even without event#3653

Merged
estringana merged 2 commits intomasterfrom
estringana/send-reponse-headers-whithout-event
Feb 19, 2026
Merged

Send response headers on meta even without event#3653
estringana merged 2 commits intomasterfrom
estringana/send-reponse-headers-whithout-event

Conversation

@estringana
Copy link
Contributor

Description

Extension should make sure that response content-type and content-length are always presents on span tags. Even without appsec events

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-official
Copy link

datadog-official bot commented Feb 16, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1066 Tests failed

❄️ Known flaky: testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionSpecific70.php:28
...
❄️ Known flaky: testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithNoArguments
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:35
tests/Common/RetryTraitVersionSpecific70.php:28
...
❄️ Known flaky: testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V3_10/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionGeneric.php:28
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5909493 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-02-19 10:42:21

Comparing candidate commit 5909493 in PR branch estringana/send-reponse-headers-whithout-event with baseline commit 6eb0128 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana force-pushed the estringana/send-reponse-headers-whithout-event branch from 0a92b8e to 1a708f7 Compare February 17, 2026 09:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (6eb0128) to head (5909493).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3653      +/-   ##
==========================================
- Coverage   62.22%   62.11%   -0.11%     
==========================================
  Files         141      141              
  Lines       13387    13388       +1     
  Branches     1753     1753              
==========================================
- Hits         8330     8316      -14     
- Misses       4260     4273      +13     
- Partials      797      799       +2     
Files with missing lines Coverage Δ
appsec/src/extension/tags.c 80.33% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb0128...5909493. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@estringana estringana force-pushed the estringana/send-reponse-headers-whithout-event branch from 1a708f7 to 929d678 Compare February 17, 2026 09:56
@estringana estringana force-pushed the estringana/send-reponse-headers-whithout-event branch from 19c548d to d7616ce Compare February 18, 2026 17:15
@estringana estringana force-pushed the estringana/send-reponse-headers-whithout-event branch from d7616ce to 5909493 Compare February 19, 2026 10:02
@estringana estringana marked this pull request as ready for review February 19, 2026 10:22
@estringana estringana requested a review from a team as a code owner February 19, 2026 10:22
@estringana estringana merged commit f785afe into master Feb 19, 2026
1908 of 2071 checks passed
@estringana estringana deleted the estringana/send-reponse-headers-whithout-event branch February 19, 2026 15:37
@github-actions github-actions bot added this to the 1.17.0 milestone Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments