Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions appsec/src/extension/tags.c
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ static void _add_basic_tags_to_meta(
_dd_http_client_ip(meta_ht);

_dd_request_headers(meta_ht, _server, headers);
_dd_response_headers(meta_ht);
}

// NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
Expand Down
4 changes: 4 additions & 0 deletions appsec/tests/extension/ancillary_tags.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,8 @@ Array
[http.request.headers.x-cloud-trace-context] => cloudtracecontext
[http.request.headers.x-sigsci-requestid] => sigscirequestid
[http.request.headers.x-sigsci-tags] => sigscitags
[http.response.headers.content-encoding] => foobar
[http.response.headers.content-language] => pt_PT
[http.response.headers.content-length] => 42
[http.response.headers.content-type] => application/json
)
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,26 @@ trait CommonTests {
assert span.meta."_dd.appsec.event_rules.version" != ''
}

@Test
void 'trace without event'() {
def respContentType = null
def respContentLength = null
def trace = container.traceFromRequest('/hello.php') { HttpResponse<InputStream> resp ->
assert resp.statusCode() == 200
def headerContentType = resp.headers().firstValue('Content-Type')
if (headerContentType.isPresent()) {
respContentType = headerContentType.get()
}
}

Span span = trace.first()
assert span.metrics."_dd.appsec.enabled" == 1.0d
assert respContentType != null && respContentType.length() > 0
assert span.meta."http.response.headers.content-type" == respContentType
assert span.meta."http.response.headers.content-encoding" == 'foobar'
assert span.meta."http.response.headers.content-language" == 'en'
}

@Test
void 'trace with an attack'() {
HttpRequest req = container.buildReq('/hello.php')
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
<?php
echo 'Hello world!';
header('Content-Encoding: foobar');
header('Content-Language: en');

$content = "Hello world!";

echo $content;

Loading