-
Notifications
You must be signed in to change notification settings - Fork 305
redesign conversion summary report #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
redesign conversion summary report #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR redesigns the conversion summary report by moving summary statistics from a separate section below the title into the chart headers themselves. The change improves the visual layout by consolidating related information directly with each chart rather than displaying it separately at the top.
- Removed the summary loop from the template that previously displayed statistics as a list
- Added summary statistics directly to chart titles using HTML line breaks
- Updated chart titles to include both conversion percentages and total request counts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| analytics/templates/analytics/summary_change_list.html | Removed the loop that displayed summary statistics separately, now that this information is shown in chart headers |
| analytics/site/conversionadmin.py | Added mark_safe imports and updated chart titles to include summary statistics with HTML formatting (line breaks) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@tibisabau Hi, thanks for contribution! |
Summary
PR for issue #344. The summary below the title has been deleted and moved to the respective chart headers. Closes #344
The Code was generated using GitHub Copilot.
Pull Request Checklist
Put an x in the boxes that apply.
When applicable