Add building scene layer #446
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
changed the title
shubham7109
requested changes
Dec 12, 2025
Collaborator
shubham7109
left a comment
shubham7109
left a comment
There was a problem hiding this comment.
I'm unable to test the sample locally, please update the arcgisMapsKotlinVersion to consume LSV build.
Seems like the layer may take a while to load, could you use the shared LoadingDialog component to display on launch and dismissed using the LaunchedEffect?
Comment on lines
+46
to
+47
| import com.arcgismaps.toolkit.geoviewcompose.LocalSceneView | ||
| import com.arcgismaps.toolkit.geoviewcompose.LocalSceneViewProxy |
Collaborator
There was a problem hiding this comment.
Libs toml will need to be updated with v.next to allow local builds use LSV.
Comment on lines
+58
to
+73
| val elevationSource = remember { | ||
| ArcGISTiledElevationSource("https://elevation3d.arcgis.com/arcgis/rest/services/WorldElevation3D/Terrain3D/ImageServer") | ||
| } | ||
|
|
||
| val buildingSceneLayer = remember { | ||
| BuildingSceneLayer("https://www.arcgis.com/home/item.html?id=669f6279c579486eb4a0acc7eb59d7ca") | ||
| .apply { | ||
| // Sets the altitude offset of the building scene layer. | ||
| // Upon first inspection of the model, it does not line up with the global | ||
| // elevation layer perfectly. To fix this, add an altitude offset to align | ||
| // the model with the ground surface. | ||
| altitudeOffset = 1.0 | ||
| } | ||
| } | ||
|
|
||
| val localSceneViewProxy = remember { LocalSceneViewProxy() } |
Collaborator
There was a problem hiding this comment.
Seems like this sample does not use a view model, if so we should I would recommend remember { mutableStateOf(...) } as needed to allow updates to pass down to the GeoView.
| // The full model sublayer which contains all the features of the building. | ||
| var fullModelSublayer: BuildingSublayer? = null | ||
|
|
||
| val arcGISScene = remember { |
Collaborator
There was a problem hiding this comment.
Should this scene also be a mutable state of if not using a view model?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to add a new Kotlin sample "add building scene layer" in
layerscategory. Design is here.Links and Data
Sample Epic:
runtime/kotlin/issues/ISSUE_NUMBERWhat To Review
README.mdandREADME.metadata.jsonfilesHow to Test
Run the sample on the sample viewer or the repo.
Screenshots